From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80CDCC433DF for ; Sat, 25 Jul 2020 15:50:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5FDE1206E3 for ; Sat, 25 Jul 2020 15:50:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="TKpyxyvQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727771AbgGYPug (ORCPT ); Sat, 25 Jul 2020 11:50:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726995AbgGYPug (ORCPT ); Sat, 25 Jul 2020 11:50:36 -0400 Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E55A7C08C5DB for ; Sat, 25 Jul 2020 08:50:35 -0700 (PDT) Received: by mail-pf1-x441.google.com with SMTP id t11so6828386pfq.11 for ; Sat, 25 Jul 2020 08:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=bcLcYtn/5EXjyyKK+pdJfQFFgGu5Nf11dS5S/Z/JYdA=; b=TKpyxyvQofSWhMw/ULpw8l0YUvfCsNuArU58WtzTf5mmfKXj9cJdscPlLD28Wr1rZl RLTlzE5cJeKX8910OpbdxX9OgYKEttD58FM/UdbzhmKORezH7LFec2H2qaPUMoc12959 u1nOlANeu/eFp+031emHEa3vJAeascp/sG7Rw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bcLcYtn/5EXjyyKK+pdJfQFFgGu5Nf11dS5S/Z/JYdA=; b=lT5dSc89ivmjw4CI92Izy9RqVieUCaKK3EKlm3OGDVRK6QYMoij2JKZ37YJPxIclxL 7DZb6Z3ugTphfBEatsAJkgHdRV4/vb+VbDo+T5a49UqNGKTVWD9Ify+XfitxDkJ8VYAT zA7TXJLVReTQt71fZA7ES9SvTcWGESbRR+N20KIkm14/sMET0GfffHKhHQ919x+EG3aX VdcTXgiNMM6AV0cdXrge/UoHOsGSoYxTmbrzQNLRmeZi8w4B/aRrLkRaPdNI1B1TFEIP NabUCPdb+K8rK0PQdW1gOYC3KLRAJnIGVLLjnBmilbDlEwjKspbFD2Ay1QiAMwJy3YP9 tz9Q== X-Gm-Message-State: AOAM532upAHOspJJ3VP+VCfJD9/EnquV+QrKw+pb/hqpBAyRoDdniHqN wrORGgAKxKpAkhE7uNl5fI9yNg== X-Google-Smtp-Source: ABdhPJwA2gHcQ6pTTJcKgRnxdYSRIi/wTmQWm8YUexB647QP8HPj8ygmB8SXoUSnqs/kfBozVfUi5g== X-Received: by 2002:aa7:9ac3:: with SMTP id x3mr13028951pfp.261.1595692235526; Sat, 25 Jul 2020 08:50:35 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id m31sm9813112pjb.52.2020.07.25.08.50.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jul 2020 08:50:34 -0700 (PDT) Date: Sat, 25 Jul 2020 08:50:33 -0700 From: Kees Cook To: Greg Kroah-Hartman Cc: stable@vger.kernel.org, Scott Branden , Mimi Zohar , Luis Chamberlain , Jessica Yu , SeongJae Park , KP Singh , linux-efi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 03/19] firmware_loader: EFI firmware loader must handle pre-allocated buffer Message-ID: <202007250849.2B58CD3B@keescook> References: <20200724213640.389191-1-keescook@chromium.org> <20200724213640.389191-4-keescook@chromium.org> <20200725100700.GB1073708@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200725100700.GB1073708@kroah.com> Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Sat, Jul 25, 2020 at 12:07:00PM +0200, Greg Kroah-Hartman wrote: > On Fri, Jul 24, 2020 at 02:36:24PM -0700, Kees Cook wrote: > > The EFI platform firmware fallback would clobber any pre-allocated > > buffers. Instead, correctly refuse to reallocate when too small (as > > already done in the sysfs fallback), or perform allocation normally > > when needed. > > > > Fixes: e4c2c0ff00ec ("firmware: Add new platform fallback mechanism and firm ware_request_platform()") > > "firmware_request_platform()" :) Weird... I'm not sure where that mangling happened. Perhaps a bad cut/paste at 80 columns? Hmpf; thanks for catching. I've updated it on my end (I assume you fixed this manually, though?) Thanks! -- Kees Cook