From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5972C433E3 for ; Sat, 25 Jul 2020 17:20:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA6C12076C for ; Sat, 25 Jul 2020 17:20:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595697655; bh=tsXknhVBYEmB2CJYeY9vU2qcrD5B43pPBPyaIHl7sCk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=vsTPkgb8VjudCu2LMSAUoLLhudBfwLSk1ZJAZQzGtcoNvdVKUl0ctq8O5L35VRjqa X+UNUPcmnPtKa8Av3d+eloOxK3qJgaRlvkKltiVHX74pkkKy5w/8UnvEkWWmqy8Ott t/9WSRwz+sI/1w+JB6JUPtxS+mQpzIrK42YKve6c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726995AbgGYRUz (ORCPT ); Sat, 25 Jul 2020 13:20:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:59712 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726926AbgGYRUy (ORCPT ); Sat, 25 Jul 2020 13:20:54 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 62DC9206D8; Sat, 25 Jul 2020 17:20:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595697654; bh=tsXknhVBYEmB2CJYeY9vU2qcrD5B43pPBPyaIHl7sCk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gRrUSykOt9EXcm6iUGecAcMKn8B+gQ2uDu91Esx9bYDK9fpRh7BzoCy5yk/EPvryl PRKAUvqpxHPFfIfqOxCxoTdJ9FNBo7En15jyn746/g/l7ujY6HfgeXyylfYvO7FYU5 QHidFPL6+CVaAR5ojKH7ET3hoPO4f16GRUZsz4Hg= Date: Sat, 25 Jul 2020 19:20:50 +0200 From: Greg Kroah-Hartman To: Kees Cook Cc: stable@vger.kernel.org, Scott Branden , Mimi Zohar , Luis Chamberlain , Jessica Yu , SeongJae Park , KP Singh , linux-efi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 03/19] firmware_loader: EFI firmware loader must handle pre-allocated buffer Message-ID: <20200725172050.GA405510@kroah.com> References: <20200724213640.389191-1-keescook@chromium.org> <20200724213640.389191-4-keescook@chromium.org> <20200725100700.GB1073708@kroah.com> <202007250849.2B58CD3B@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202007250849.2B58CD3B@keescook> Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Sat, Jul 25, 2020 at 08:50:33AM -0700, Kees Cook wrote: > On Sat, Jul 25, 2020 at 12:07:00PM +0200, Greg Kroah-Hartman wrote: > > On Fri, Jul 24, 2020 at 02:36:24PM -0700, Kees Cook wrote: > > > The EFI platform firmware fallback would clobber any pre-allocated > > > buffers. Instead, correctly refuse to reallocate when too small (as > > > already done in the sysfs fallback), or perform allocation normally > > > when needed. > > > > > > Fixes: e4c2c0ff00ec ("firmware: Add new platform fallback mechanism and firm ware_request_platform()") > > > > "firmware_request_platform()" :) > > Weird... I'm not sure where that mangling happened. Perhaps a bad > cut/paste at 80 columns? Hmpf; thanks for catching. I've updated it on > my end (I assume you fixed this manually, though?) Yes, I fixed it up already, no worries. greg k-h