From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 785D7C4363C for ; Wed, 7 Oct 2020 19:26:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2DC012085B for ; Wed, 7 Oct 2020 19:26:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602098772; bh=ARBy9A0ue5dqKp5InVcHb1ElW6qKfvo+jYevu8+wq/U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=X/jlyJspRor9cZbZk/HaBInF4uyqdhA2xymWa9HwnjBEyW+yKjWh/qJsyV/WXSYhS ZWWgvlcJh3o9CvB4pbv8sGxUunucyBiRzfMtg12a1Kl0QPdMgghRoi4jbu3/ss4UHQ dPHShQUNx1T/N6g8QGaihs9FgvEKr4crFl/1oGww= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728003AbgJGT0L (ORCPT ); Wed, 7 Oct 2020 15:26:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:58166 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726671AbgJGT0L (ORCPT ); Wed, 7 Oct 2020 15:26:11 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0FA492076C; Wed, 7 Oct 2020 19:26:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602098770; bh=ARBy9A0ue5dqKp5InVcHb1ElW6qKfvo+jYevu8+wq/U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Hhvb+RWQ6CdkbJ5w0RajeI+9jps9z2eLNp+IAp5cf1HZtUwQU3SltMtME1qVb3cls 2mTPXr1+dGxa3833DrxJmXcqY6UtvMTxRygGp1olweQPVQBiMfN26qaJpn96SFe78k sWPAONQenDab5v9q+zGC5kVoxOA5GPnXxwkoIYQ8= Date: Wed, 7 Oct 2020 21:26:55 +0200 From: Greg KH To: Haitao Huang Cc: Jarkko Sakkinen , x86@kernel.org, linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Matthew Wilcox , Jethro Beekman , Chunyang Hui , Jordan Hand , Nathaniel McCallum , Seth Moore , Darren Kenny , Sean Christopherson , Suresh Siddha , andriy.shevchenko@linux.intel.com, asapek@google.com, bp@alien8.de, cedric.xing@intel.com, chenalexchen@google.com, conradparker@google.com, cyhanish@google.com, dave.hansen@intel.com, haitao.huang@intel.com, kai.huang@intel.com, kai.svahn@intel.com, kmoy@google.com, ludloff@google.com, luto@kernel.org, nhorman@redhat.com, puiterwijk@redhat.com, rientjes@google.com, tglx@linutronix.de, yaozhangx@google.com, mikko.ylinen@intel.com Subject: Re: [PATCH v39 11/24] x86/sgx: Add SGX enclave driver Message-ID: <20201007192655.GA104072@kroah.com> References: <20201003045059.665934-1-jarkko.sakkinen@linux.intel.com> <20201003045059.665934-12-jarkko.sakkinen@linux.intel.com> <20201003143925.GB800720@kroah.com> <20201004143246.GA3561@linux.intel.com> <20201005094246.GB151835@kroah.com> <20201005124221.GA191854@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: On Wed, Oct 07, 2020 at 01:09:01PM -0500, Haitao Huang wrote: > > > > There is a patch that adds "sgx/provision". > > > > > > What number in this series? > > > > It's 15/24. > > > > Don't know if this is critical. I'd prefer to keep them as is. Directory > seems natural to me and makes sense to add more under the same dir in case > there are more to come. Why is this so special that you need a subdirectory for a single driver with a mere 2 device nodes? Do any other misc drivers have a new subdirectory in /dev/ for them? thanks, greg k-h