Re: [PATCH v16 2/4] overlayfs: handle XATTR_NOSECURITY flag for get xattr method

From: kernel test robot <lkp@intel.com>
To: Mark Salyzyn <salyzyn@android.com>, linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
	kernel-team@android.com, Mark Salyzyn <salyzyn@android.com>,
	Stephen Smalley <sds@tycho.nsa.gov>,
	linux-security-module@vger.kernel.org,
	Miklos Szeredi <miklos@szeredi.hu>,
	Jonathan Corbet <corbet@lwn.net>, Vivek Goyal <vgoyal@redhat.com>,
	"Eric W . Biederman" <ebiederm@xmission.com>,
	Amir Goldstein <amir73il@gmail.com>
Subject: Re: [PATCH v16 2/4] overlayfs: handle XATTR_NOSECURITY flag for get xattr method
Date: Tue, 20 Oct 2020 01:13:14 +0800	[thread overview]
Message-ID: <202010200141.gMb76QxE-lkp@intel.com> (raw)
In-Reply-To: <20201019115239.2732422-3-salyzyn@android.com>

[-- Attachment #1: Type: text/plain, Size: 2666 bytes --]

Hi Mark,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on miklos-vfs/overlayfs-next]
[also build test ERROR on linus/master next-20201016]
[cannot apply to ext4/dev security/next-testing v5.9]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Mark-Salyzyn/overlayfs-override_creds-off-nested-get-xattr-fix/20201019-195516
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs-next
config: x86_64-randconfig-a016-20201019 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 094e9f4779eb9b5c6a49014f2f80b8cbb833572f)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/1cb141c810d73ddaf9ef64889ed4d4fed81bb453
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Mark-Salyzyn/overlayfs-override_creds-off-nested-get-xattr-fix/20201019-195516
        git checkout 1cb141c810d73ddaf9ef64889ed4d4fed81bb453
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from fs/overlayfs/super.c:18:
>> fs/overlayfs/overlayfs.h:187:67: error: too few arguments to function call, expected 6, have 5
           return __vfs_getxattr(dentry, name, value, size, XATTR_NOSECURITY);
                  ~~~~~~~~~~~~~~                                            ^
   include/linux/xattr.h:50:9: note: '__vfs_getxattr' declared here
   ssize_t __vfs_getxattr(struct dentry *dentry, struct inode *inode,
           ^
   1 error generated.

vim +187 fs/overlayfs/overlayfs.h

   181	
   182	static inline ssize_t ovl_do_getxattr(struct ovl_fs *ofs, struct dentry *dentry,
   183					      enum ovl_xattr ox, void *value,
   184					      size_t size)
   185	{
   186		const char *name = ovl_xattr(ofs, ox);
 > 187		return __vfs_getxattr(dentry, name, value, size, XATTR_NOSECURITY);
   188	}
   189	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31469 bytes --]