From: Mimi Zohar <zohar@linux.ibm.com>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: linux-integrity@vger.kernel.org,
Test <test@localhost.localdomain>,
James Morris <jmorris@namei.org>,
"Serge E . Hallyn" <serge@hallyn.com>,
linux-security-module <linux-security-module@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Eric Biggers <ebiggers@kernel.org>,
Mimi Zohar <zohar@linux.ibm.com>
Subject: [RFC PATCH 1/2] ima: don't access a file's integrity status before an IMA policy is loaded
Date: Fri, 19 Mar 2021 16:03:57 -0400 [thread overview]
Message-ID: <20210319200358.22816-1-zohar@linux.ibm.com> (raw)
From: Test <test@localhost.localdomain>
Only after an IMA policy is loaded, check, save, or update the cached
file's integrity status.
Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
---
security/integrity/ima/ima_main.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
index 9ef748ea829f..9d1196f712e1 100644
--- a/security/integrity/ima/ima_main.c
+++ b/security/integrity/ima/ima_main.c
@@ -606,6 +606,9 @@ void ima_post_create_tmpfile(struct user_namespace *mnt_userns,
struct integrity_iint_cache *iint;
int must_appraise;
+ if (!ima_policy_flag || !S_ISREG(inode->i_mode))
+ return;
+
must_appraise = ima_must_appraise(mnt_userns, inode, MAY_ACCESS,
FILE_CHECK);
if (!must_appraise)
@@ -636,6 +639,9 @@ void ima_post_path_mknod(struct user_namespace *mnt_userns,
struct inode *inode = dentry->d_inode;
int must_appraise;
+ if (!ima_policy_flag || !S_ISREG(inode->i_mode))
+ return;
+
must_appraise = ima_must_appraise(mnt_userns, inode, MAY_ACCESS,
FILE_CHECK);
if (!must_appraise)
--
2.27.0
next reply other threads:[~2021-03-19 20:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 20:03 Mimi Zohar [this message]
2021-03-19 20:03 ` [RFC PATCH 2/2] integrity: double check iint_cache was initialized Mimi Zohar
2021-03-22 7:10 ` Tetsuo Handa
2021-03-22 7:53 ` Dmitry Vyukov
2021-03-23 1:46 ` Tetsuo Handa
2021-03-23 12:09 ` Mimi Zohar
2021-03-23 13:37 ` Tetsuo Handa
2021-03-23 14:01 ` Tetsuo Handa
2021-03-23 14:47 ` Mimi Zohar
2021-03-23 15:14 ` Tetsuo Handa
2021-03-23 16:13 ` Mimi Zohar
2021-03-24 10:10 ` Tetsuo Handa
2021-03-24 11:10 ` Mimi Zohar
2021-03-24 11:20 ` Tetsuo Handa
2021-03-24 11:37 ` Dmitry Vyukov
2021-03-24 11:49 ` Mimi Zohar
2021-03-24 11:58 ` Dmitry Vyukov
2021-03-24 12:17 ` Mimi Zohar
2021-03-24 15:56 ` Casey Schaufler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210319200358.22816-1-zohar@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=dvyukov@google.com \
--cc=ebiggers@kernel.org \
--cc=jmorris@namei.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=test@localhost.localdomain \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).