archive mirror
 help / color / mirror / Atom feed
	Tom Rix <>
Subject: [PATCH v2] samples/landlock: fix path_list memory leak
Date: Wed, 28 Apr 2021 14:38:52 -0700	[thread overview]
Message-ID: <> (raw)

From: Tom Rix <>

Clang static analysis reports this error

sandboxer.c:134:8: warning: Potential leak of memory
  pointed to by 'path_list'
        ret = 0;
path_list is allocated in parse_path() but never freed.

Signed-off-by: Tom Rix <>
  - Remove NULL ptr check
 samples/landlock/sandboxer.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/samples/landlock/sandboxer.c b/samples/landlock/sandboxer.c
index 7a15910d2171..8859fc193542 100644
--- a/samples/landlock/sandboxer.c
+++ b/samples/landlock/sandboxer.c
@@ -134,6 +134,7 @@ static int populate_ruleset(
 	ret = 0;
+	free(path_list);
 	return ret;

             reply	other threads:[~2021-04-28 21:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-28 21:38 trix [this message]
2021-04-29  9:22 ` [PATCH v2] samples/landlock: fix path_list memory leak Mickaël Salaün

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).