linux-security-module.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] samples/landlock: fix path_list memory leak
@ 2021-04-28 21:38 trix
  2021-04-29  9:22 ` Mickaël Salaün
  0 siblings, 1 reply; 2+ messages in thread
From: trix @ 2021-04-28 21:38 UTC (permalink / raw)
  To: mic, nathan, ndesaulniers
  Cc: linux-security-module, linux-kernel, clang-built-linux, Tom Rix

From: Tom Rix <trix@redhat.com>

Clang static analysis reports this error

sandboxer.c:134:8: warning: Potential leak of memory
  pointed to by 'path_list'
        ret = 0;
              ^
path_list is allocated in parse_path() but never freed.

Signed-off-by: Tom Rix <trix@redhat.com>
---
v2:
  - Remove NULL ptr check
---
 samples/landlock/sandboxer.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/samples/landlock/sandboxer.c b/samples/landlock/sandboxer.c
index 7a15910d2171..8859fc193542 100644
--- a/samples/landlock/sandboxer.c
+++ b/samples/landlock/sandboxer.c
@@ -134,6 +134,7 @@ static int populate_ruleset(
 	ret = 0;
 
 out_free_name:
+	free(path_list);
 	free(env_path_name);
 	return ret;
 }
-- 
2.26.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-29  9:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-28 21:38 [PATCH v2] samples/landlock: fix path_list memory leak trix
2021-04-29  9:22 ` Mickaël Salaün

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).