From: "Serge E. Hallyn" <serge@hallyn.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
linux-security-module@vger.kernel.org,
Mimi Zohar <zohar@us.ibm.com>
Subject: Re: [PATCH v1] efi: Don't use knowledge about efi_guid_t internals
Date: Thu, 26 Aug 2021 15:27:36 -0500 [thread overview]
Message-ID: <20210826202736.GA29151@mail.hallyn.com> (raw)
In-Reply-To: <CAMj1kXG6cZK+j-oEURuvLgntZxL-maUs0zk0UexHs3=S0wbLug@mail.gmail.com>
On Thu, Aug 26, 2021 at 06:37:06PM +0200, Ard Biesheuvel wrote:
> On Thu, 26 Aug 2021 at 17:08, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > On Thu, Jun 10, 2021 at 05:05:55PM +0200, Ard Biesheuvel wrote:
> > > On Mon, 7 Jun 2021 at 19:11, Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > On Tue, Feb 09, 2021 at 05:51:45PM +0100, Ard Biesheuvel wrote:
> > > > > On Tue, 9 Feb 2021 at 17:45, Andy Shevchenko
> > > > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > > >
> > > > > > When print GUIDs supply pointer to the efi_guid_t (guid_t) type rather
> > > > > > its internal members.
> > > > > >
> > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > > >
> > > > > Acked-by: Ard Biesheuvel <ardb@kernel.org>
> > > >
> > > > Thanks!
> > > >
> > > > Can we get this applied, please?
> > >
> > > Apologies, this one slipped behind the desk.
> >
> > Do I need to resend it?
> >
>
> No, but I need an ack from James or Serge as it targets security/
It looks correct to me, based on Documentation/core-api/printk-formats.rst
and existing examples.
Reviewed-by: Serge Hallyn <serge@hallyn.com>
thanks
-serge
next prev parent reply other threads:[~2021-08-26 20:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 16:45 [PATCH v1] efi: Don't use knowledge about efi_guid_t internals Andy Shevchenko
2021-02-09 16:51 ` Ard Biesheuvel
2021-06-07 17:11 ` Andy Shevchenko
2021-06-10 15:05 ` Ard Biesheuvel
2021-08-26 15:08 ` Andy Shevchenko
2021-08-26 16:37 ` Ard Biesheuvel
2021-08-26 20:27 ` Serge E. Hallyn [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-10-15 11:50 Andy Shevchenko
2021-01-02 21:36 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210826202736.GA29151@mail.hallyn.com \
--to=serge@hallyn.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ardb@kernel.org \
--cc=jmorris@namei.org \
--cc=linux-security-module@vger.kernel.org \
--cc=zohar@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).