From: kernel test robot <lkp@intel.com>
To: Casey Schaufler <casey@schaufler-ca.com>,
paul@paul-moore.com, linux-security-module@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, jmorris@namei.org,
keescook@chromium.org, john.johansen@canonical.com,
penguin-kernel@i-love.sakura.ne.jp,
stephen.smalley.work@gmail.com, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org, mic@digikod.net
Subject: Re: [PATCH v6 04/11] LSM: syscalls for current process attributes
Date: Thu, 23 Feb 2023 20:49:52 +0800 [thread overview]
Message-ID: <202302232007.dcqfhRnw-lkp@intel.com> (raw)
In-Reply-To: <20230222200838.8149-5-casey@schaufler-ca.com>
Hi Casey,
I love your patch! Perhaps something to improve:
[auto build test WARNING on tip/perf/core]
[also build test WARNING on acme/perf/core shuah-kselftest/next shuah-kselftest/fixes v6.2]
[cannot apply to linus/master next-20230223]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Casey-Schaufler/LSM-Maintain-a-table-of-LSM-attribute-data/20230223-050902
patch link: https://lore.kernel.org/r/20230222200838.8149-5-casey%40schaufler-ca.com
patch subject: [PATCH v6 04/11] LSM: syscalls for current process attributes
config: x86_64-rhel-8.3 (https://download.01.org/0day-ci/archive/20230223/202302232007.dcqfhRnw-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/04ba82c1bd629c2114ad851b4723d6e8b0f9d08f
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Casey-Schaufler/LSM-Maintain-a-table-of-LSM-attribute-data/20230223-050902
git checkout 04ba82c1bd629c2114ad851b4723d6e8b0f9d08f
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 olddefconfig
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202302232007.dcqfhRnw-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> security/lsm_syscalls.c:61:5: warning: no previous prototype for 'lsm_name_to_attr' [-Wmissing-prototypes]
61 | u64 lsm_name_to_attr(const char *name)
| ^~~~~~~~~~~~~~~~
vim +/lsm_name_to_attr +61 security/lsm_syscalls.c
51
52 /**
53 * lsm_name_to_attr - map an LSM attribute name to its ID
54 * @name: name of the attribute
55 *
56 * Look the given @name up in the table of know attribute names.
57 *
58 * Returns the LSM attribute value associated with @name, or 0 if
59 * there is no mapping.
60 */
> 61 u64 lsm_name_to_attr(const char *name)
62 {
63 int i;
64
65 for (i = 0; i < ARRAY_SIZE(lsm_attr_names); i++)
66 if (!strcmp(name, lsm_attr_names[i].name))
67 return lsm_attr_names[i].attrs;
68 return 0;
69 }
70
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next prev parent reply other threads:[~2023-02-23 12:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230222200838.8149-1-casey.ref@schaufler-ca.com>
2023-02-22 20:08 ` [PATCH v6 00/11] LSM: Three basic syscalls Casey Schaufler
2023-02-22 20:08 ` [PATCH v6 01/11] LSM: Identify modules by more than name Casey Schaufler
2023-02-22 20:08 ` [PATCH v6 02/11] LSM: Maintain a table of LSM attribute data Casey Schaufler
2023-02-22 20:08 ` [PATCH v6 03/11] proc: Use lsmids instead of lsm names for attrs Casey Schaufler
2023-02-22 20:08 ` [PATCH v6 04/11] LSM: syscalls for current process attributes Casey Schaufler
2023-02-23 4:57 ` kernel test robot
2023-02-23 8:32 ` kernel test robot
2023-02-23 12:49 ` kernel test robot [this message]
2023-03-03 18:41 ` Arnd Bergmann
2023-03-07 11:51 ` Mickaël Salaün
2023-03-09 2:30 ` Casey Schaufler
2023-03-14 22:00 ` Paul Moore
2023-03-07 11:56 ` Mickaël Salaün
2023-03-07 17:04 ` Casey Schaufler
2023-03-07 17:13 ` Casey Schaufler
2023-03-07 14:57 ` Florian Weimer
2023-02-22 20:08 ` [PATCH v6 05/11] LSM: Create lsm_module_list system call Casey Schaufler
2023-03-03 18:32 ` Arnd Bergmann
2023-03-07 11:33 ` Mickaël Salaün
2023-04-06 16:31 ` Casey Schaufler
2023-02-22 20:08 ` [PATCH v6 06/11] LSM: wireup Linux Security Module syscalls Casey Schaufler
2023-02-23 10:19 ` Geert Uytterhoeven
2023-03-03 18:34 ` Arnd Bergmann
2023-02-22 20:08 ` [PATCH v6 07/11] LSM: Helpers for attribute names and filling an lsm_ctx Casey Schaufler
2023-02-22 20:08 ` [PATCH v6 08/11] Smack: implement setselfattr and getselfattr hooks Casey Schaufler
2023-02-22 20:08 ` [PATCH v6 09/11] AppArmor: Add selfattr hooks Casey Schaufler
2023-02-22 20:08 ` [PATCH v6 10/11] SELinux: " Casey Schaufler
2023-02-22 20:08 ` [PATCH v6 11/11] LSM: selftests for Linux Security Module syscalls Casey Schaufler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202302232007.dcqfhRnw-lkp@intel.com \
--to=lkp@intel.com \
--cc=casey@schaufler-ca.com \
--cc=jmorris@namei.org \
--cc=john.johansen@canonical.com \
--cc=keescook@chromium.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mic@digikod.net \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=paul@paul-moore.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=stephen.smalley.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).