linux-security-module.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Mickaël Salaün" <mic@digikod.net>
To: trix@redhat.com, nathan@kernel.org, ndesaulniers@google.com
Cc: linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com,
	James Morris <jmorris@namei.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH v2] samples/landlock: fix path_list memory leak
Date: Thu, 29 Apr 2021 11:22:06 +0200	[thread overview]
Message-ID: <20b46fb2-94e2-989a-9102-5e5c7be3b8ba@digikod.net> (raw)
In-Reply-To: <20210428213852.2874324-1-trix@redhat.com>


On 28/04/2021 23:38, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> Clang static analysis reports this error
> 
> sandboxer.c:134:8: warning: Potential leak of memory
>   pointed to by 'path_list'
>         ret = 0;
>               ^
> path_list is allocated in parse_path() but never freed.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Reviewed-by: Mickaël Salaün <mic@linux.microsoft.com>

Previous version:
https://lore.kernel.org/r/20210427183755.2790654-1-trix@redhat.com

> ---
> v2:
>   - Remove NULL ptr check
> ---
>  samples/landlock/sandboxer.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/samples/landlock/sandboxer.c b/samples/landlock/sandboxer.c
> index 7a15910d2171..8859fc193542 100644
> --- a/samples/landlock/sandboxer.c
> +++ b/samples/landlock/sandboxer.c
> @@ -134,6 +134,7 @@ static int populate_ruleset(
>  	ret = 0;
>  
>  out_free_name:
> +	free(path_list);
>  	free(env_path_name);
>  	return ret;
>  }
> 

      reply	other threads:[~2021-04-29  9:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-28 21:38 [PATCH v2] samples/landlock: fix path_list memory leak trix
2021-04-29  9:22 ` Mickaël Salaün [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20b46fb2-94e2-989a-9102-5e5c7be3b8ba@digikod.net \
    --to=mic@digikod.net \
    --cc=clang-built-linux@googlegroups.com \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=torvalds@linux-foundation.org \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).