From: Roberto Sassu <roberto.sassu@huawei.com>
To: Mimi Zohar <zohar@linux.ibm.com>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: <david.safford@ge.com>, <monty.wiseman@ge.com>,
<linux-integrity@vger.kernel.org>,
<linux-security-module@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <silviu.vlasceanu@huawei.com>
Subject: Re: [PATCH v6 4/7] tpm: modify tpm_pcr_read() definition to pass a TPM hash algorithm
Date: Fri, 7 Dec 2018 15:51:33 +0100 [thread overview]
Message-ID: <2f6c0365-6c17-2da1-9f5b-3c8e5cc301b2@huawei.com> (raw)
In-Reply-To: <1544125756.4017.70.camel@linux.ibm.com>
On 12/6/2018 8:49 PM, Mimi Zohar wrote:
> On Wed, 2018-12-05 at 15:31 -0500, Mimi Zohar wrote:
>> On Tue, 2018-12-04 at 15:40 -0800, Jarkko Sakkinen wrote:
>>> On Tue, Dec 04, 2018 at 09:21:35AM +0100, Roberto Sassu wrote:
>>>> Currently the TPM driver allows other kernel subsystems to read only the
>>>> SHA1 PCR bank. This patch modifies the parameters of tpm_pcr_read() and
>>>> tpm2_pcr_read() to pass a tpm_digest structure, which contains the desired
>>>> hash algorithm. Also, since commit 125a22105410 ("tpm: React correctly to
>>>> RC_TESTING from TPM 2.0 self tests") removed the call to tpm2_pcr_read(),
>>>> the new parameter is expected to be always not NULL.
>>>>
>>>> Due to the API change, IMA functions have been modified.
>>>>
>>>> Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
>>>> Acked-by: Mimi Zohar <zohar@linux.ibm.com>
>>>
>>> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>>>
>>> Mimi, Nayna, can you help with testing this (because of the IMA change)?
>>
>> It's up & running and the measurement list verifies against the TPM
>> PCR. Although this system has two algorithms enabled, all of the PCRs
>> are allocated for one algorithm and none for the other. I'm still
>> looking around for another system with PCR 10 enabled for multiple
>> algorithms.
>
> PCRs for sha1 and sha256 algorithms are being updated and the
> measurement list verifies against the SHA1 PCR-10.
>
> Roberto, have you added support in ima-evm-utils to validate the other
> banks?
I modified IMA LTP.
Roberto
> Mimi
>
--
HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB 56063
Managing Director: Bo PENG, Jian LI, Yanli SHI
next prev parent reply other threads:[~2018-12-07 14:52 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 8:21 [PATCH v6 0/7] tpm: retrieve digest size of unknown algorithms from TPM Roberto Sassu
2018-12-04 8:21 ` [PATCH v6 1/7] tpm: dynamically allocate the allocated_banks array Roberto Sassu
2018-12-04 23:18 ` Jarkko Sakkinen
2018-12-06 17:56 ` Roberto Sassu
2018-12-12 18:32 ` Jarkko Sakkinen
2018-12-13 8:14 ` Roberto Sassu
2018-12-11 21:01 ` Ken Goldman
2018-12-04 8:21 ` [PATCH v6 2/7] tpm: add _head suffix to tcg_efi_specid_event and tcg_pcr_event2 Roberto Sassu
2018-12-04 23:26 ` Jarkko Sakkinen
2018-12-09 12:10 ` Nayna Jain
2018-12-04 8:21 ` [PATCH v6 3/7] tpm: rename and export tpm2_digest and tpm2_algorithms Roberto Sassu
2018-12-04 8:21 ` [PATCH v6 4/7] tpm: modify tpm_pcr_read() definition to pass a TPM hash algorithm Roberto Sassu
2018-12-04 23:40 ` Jarkko Sakkinen
2018-12-05 20:31 ` Mimi Zohar
2018-12-06 19:49 ` Mimi Zohar
2018-12-07 14:51 ` Roberto Sassu [this message]
2018-12-09 20:32 ` Mimi Zohar
2018-12-10 7:55 ` Roberto Sassu
2018-12-06 8:14 ` Nayna Jain
2018-12-12 18:29 ` Jarkko Sakkinen
2018-12-09 12:04 ` Nayna Jain
2018-12-04 8:21 ` [PATCH v6 5/7] tpm: retrieve digest size of unknown algorithms with PCR read Roberto Sassu
2018-12-04 23:53 ` Jarkko Sakkinen
2018-12-06 18:00 ` Roberto Sassu
2018-12-12 18:16 ` Jarkko Sakkinen
2018-12-04 8:21 ` [PATCH v6 6/7] tpm: ensure that the output of PCR read contains the correct digest size Roberto Sassu
2018-12-05 0:09 ` Jarkko Sakkinen
2018-12-05 0:46 ` Jarkko Sakkinen
2018-12-06 18:07 ` Roberto Sassu
2018-12-12 18:18 ` Jarkko Sakkinen
2018-12-04 8:21 ` [PATCH v6 7/7] tpm: pass an array of tpm_bank_list structures to tpm_pcr_extend() Roberto Sassu
2018-12-05 0:14 ` Jarkko Sakkinen
2018-12-06 18:09 ` Roberto Sassu
2018-12-12 18:25 ` Jarkko Sakkinen
2018-12-06 18:38 ` Roberto Sassu
2018-12-12 18:27 ` Jarkko Sakkinen
2018-12-13 7:57 ` Roberto Sassu
2018-12-14 7:58 ` Jarkko Sakkinen
2018-12-05 0:21 ` [PATCH v6 0/7] tpm: retrieve digest size of unknown algorithms from TPM Jarkko Sakkinen
2018-12-05 0:23 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f6c0365-6c17-2da1-9f5b-3c8e5cc301b2@huawei.com \
--to=roberto.sassu@huawei.com \
--cc=david.safford@ge.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=monty.wiseman@ge.com \
--cc=silviu.vlasceanu@huawei.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).