[PATCH] ima: Fix misuse of dereference of pointer in template_desc_init_fields()

* [PATCH] ima: Fix misuse of dereference of pointer in template_desc_init_fields()
@ 2022-11-12  9:27 Xiu Jianfeng
  2022-11-14  8:37 ` Roberto Sassu
  0 siblings, 1 reply; 3+ messages in thread
From: Xiu Jianfeng @ 2022-11-12  9:27 UTC (permalink / raw)
  To: zohar, dmitry.kasatkin, paul, jmorris, serge, roberto.sassu
  Cc: linux-integrity, linux-security-module, linux-kernel, roberto.sassu

The input parameter @fields is type of struct ima_template_field ***, so
when allocates array memory for @fields, the size of element should be
sizeof(**field) instead of sizeof(*field).

Actually the original code would not cause any runtime error, but it's
better to make it logically right.

Fixes: adf53a778a0a ("ima: new templates management mechanism")
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
---
 security/integrity/ima/ima_template.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/security/integrity/ima/ima_template.c b/security/integrity/ima/ima_template.c
index 49f0626928a1..04c49f05cb74 100644
--- a/security/integrity/ima/ima_template.c
+++ b/security/integrity/ima/ima_template.c
@@ -245,11 +245,11 @@ int template_desc_init_fields(const char *template_fmt,
 	}
 
 	if (fields && num_fields) {
-		*fields = kmalloc_array(i, sizeof(*fields), GFP_KERNEL);
+		*fields = kmalloc_array(i, sizeof(**fields), GFP_KERNEL);
 		if (*fields == NULL)
 			return -ENOMEM;
 
-		memcpy(*fields, found_fields, i * sizeof(*fields));
+		memcpy(*fields, found_fields, i * sizeof(**fields));
 		*num_fields = i;
 	}
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread