linux-security-module.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Casey Schaufler <casey@schaufler-ca.com>
To: Simon McVittie <smcv@collabora.com>
Cc: casey.schaufler@intel.com, jmorris@namei.org,
	linux-security-module@vger.kernel.org, selinux@vger.kernel.org,
	keescook@chromium.org, john.johansen@canonical.com,
	penguin-kernel@i-love.sakura.ne.jp, paul@paul-moore.com,
	sds@tycho.nsa.gov, casey@schaufler-ca.com
Subject: Re: [PATCH v10 13/25] LSM: Specify which LSM to display
Date: Tue, 29 Oct 2019 08:44:54 -0700	[thread overview]
Message-ID: <36a3a1a0-2082-11e6-021a-f2d5713f707d@schaufler-ca.com> (raw)
In-Reply-To: <20191029144408.GA26815@horizon>

On 10/29/2019 7:44 AM, Simon McVittie wrote:
> On Thu, 24 Oct 2019 at 13:52:16 -0700, Casey Schaufler wrote:
>> Create a new entry "display" in /proc/.../attr for controlling
>> which LSM security information is displayed for a process.
> It still isn't immediately obvious to me from the commit message whether
> the "..." stands for the pid of the process that will read LSM information,
> or the pid of the process whose LSM information will be read.

For all practical purposes "..." will be "self". You can read the
attr/display of another process, but I don't know where that would
be useful. You can't write to the attr/display of an different process.

>
> I believe the intended meaning was the former? So perhaps
>
>     Create a new entry "display" in /proc/$reader/attr that controls
>     which LSM security information will be displayed when the process
>     $reader reads LSM information.
>
>     (Note that when $reader reads /proc/$subject/attr/current for
>     $reader != $subject, it is /proc/$reader/attr/display that controls
>     what is displayed there, not /proc/$subject/attr/display.)
>
> The commit that introduces /proc/.../attr/context could probably
> benefit from similar treatment - maybe it could be referred to as
> /proc/$subject/attr/context?

Thanks. I'll work on making it clearer.

>
>     smcv


  reply	other threads:[~2019-10-29 15:45 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24 20:52 [PATCH v10 00/25] LSM: Module stacking for AppArmor Casey Schaufler
2019-10-24 20:52 ` [PATCH v10 01/25] LSM: Infrastructure management of the sock security Casey Schaufler
2019-10-24 20:52 ` [PATCH v10 02/25] LSM: Create and manage the lsmblob data structure Casey Schaufler
2019-10-24 20:52 ` [PATCH v10 03/25] LSM: Use lsmblob in security_audit_rule_match Casey Schaufler
2019-10-24 20:52 ` [PATCH v10 04/25] LSM: Use lsmblob in security_kernel_act_as Casey Schaufler
2019-10-24 20:52 ` [PATCH v10 05/25] net: Prepare UDS for security module stacking Casey Schaufler
2019-10-24 20:52 ` [PATCH v10 06/25] LSM: Use lsmblob in security_secctx_to_secid Casey Schaufler
2019-10-24 20:52 ` [PATCH v10 07/25] LSM: Use lsmblob in security_secid_to_secctx Casey Schaufler
2019-10-24 20:52 ` [PATCH v10 08/25] LSM: Use lsmblob in security_ipc_getsecid Casey Schaufler
2019-10-24 20:52 ` [PATCH v10 09/25] LSM: Use lsmblob in security_task_getsecid Casey Schaufler
2019-10-24 20:52 ` [PATCH v10 10/25] LSM: Use lsmblob in security_inode_getsecid Casey Schaufler
2019-10-24 20:52 ` [PATCH v10 11/25] LSM: Use lsmblob in security_cred_getsecid Casey Schaufler
2019-10-24 20:52 ` [PATCH v10 12/25] IMA: Change internal interfaces to use lsmblobs Casey Schaufler
2019-10-24 20:52 ` [PATCH v10 13/25] LSM: Specify which LSM to display Casey Schaufler
2019-10-28 15:25   ` Stephen Smalley
2019-10-29 14:44   ` Simon McVittie
2019-10-29 15:44     ` Casey Schaufler [this message]
2019-10-24 20:52 ` [PATCH v10 14/25] LSM: Ensure the correct LSM context releaser Casey Schaufler
2019-10-24 20:52 ` [PATCH v10 15/25] LSM: Use lsmcontext in security_secid_to_secctx Casey Schaufler
2019-10-24 20:52 ` [PATCH v10 16/25] LSM: Use lsmcontext in security_dentry_init_security Casey Schaufler
2019-10-24 20:52 ` [PATCH v10 17/25] LSM: Use lsmcontext in security_inode_getsecctx Casey Schaufler
2019-10-24 20:52 ` [PATCH v10 18/25] LSM: security_secid_to_secctx in netlink netfilter Casey Schaufler
2019-10-24 20:52 ` [PATCH v10 19/25] NET: Store LSM netlabel data in a lsmblob Casey Schaufler
2019-10-24 20:52 ` [PATCH v10 20/25] LSM: Verify LSM display sanity in binder Casey Schaufler
2019-10-24 20:52 ` [PATCH v10 21/25] Audit: Add subj_LSM fields when necessary Casey Schaufler
2019-10-24 20:52 ` [PATCH v10 22/25] Audit: Include object data for all security modules Casey Schaufler
2019-10-24 20:52 ` [PATCH v10 23/25] NET: Add SO_PEERCONTEXT for multiple LSMs Casey Schaufler
2019-10-24 20:52 ` [PATCH v10 24/25] LSM: Add /proc attr entry for full LSM context Casey Schaufler
2019-10-24 20:52 ` [PATCH v10 25/25] AppArmor: Remove the exclusive flag Casey Schaufler
2019-10-29 14:53 ` [PATCH v10 00/25] LSM: Module stacking for AppArmor Stephen Smalley
2019-10-29 15:51   ` Casey Schaufler
2019-11-06 10:40     ` James Morris
2019-11-06 16:11       ` Casey Schaufler
2019-11-12 23:59 Casey Schaufler
2019-11-13  0:00 ` [PATCH v10 13/25] LSM: Specify which LSM to display Casey Schaufler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36a3a1a0-2082-11e6-021a-f2d5713f707d@schaufler-ca.com \
    --to=casey@schaufler-ca.com \
    --cc=casey.schaufler@intel.com \
    --cc=jmorris@namei.org \
    --cc=john.johansen@canonical.com \
    --cc=keescook@chromium.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=sds@tycho.nsa.gov \
    --cc=selinux@vger.kernel.org \
    --cc=smcv@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).