Linux-Security-Module Archive on lore.kernel.org
 help / color / Atom feed
From: Chris von Recklinghausen <crecklin@redhat.com>
To: David Howells <dhowells@redhat.com>
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	James Morris <jmorris@namei.org>,
	"Serge E . Hallyn" <serge@hallyn.com>,
	keyrings@vger.kernel.org, linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org, Waiman Long <longman@redhat.com>
Subject: Re: [PATCH] security/keyring: avoid pagefaults in keyring_read_iterator
Date: Fri, 25 Oct 2019 07:10:29 -0400
Message-ID: <3c87bfba-9dc9-665f-17e8-0656e87c658b@redhat.com> (raw)
In-Reply-To: <b8aa0f7c-0a90-efae-9fb7-aa85b19a0d9a@redhat.com>

On 10/21/2019 11:46 AM, Chris von Recklinghausen wrote:
> On 10/21/2019 10:21 AM, David Howells wrote:
>> Chris von Recklinghausen <crecklin@redhat.com> wrote:
>>
>>> The put_user call from keyring_read_iterator caused a page fault which
>>> attempts to lock mm->mmap_sem and type->lock_class (key->sem) in the reverse
>>> order that keyring_read_iterator did, thus causing the circular locking
>>> dependency.
>>>
>>> Remedy this by using access_ok and __put_user instead of put_user so we'll
>>> return an error instead of faulting in the page.
>> I wonder if it's better to create a kernel buffer outside of the lock in
>> keyctl_read_key().  Hmmm...  The reason I didn't want to do that is that
>> keyrings have don't have limits on the size.  Maybe that's not actually a
>> problem, since 1MiB would be able to hold a list of a quarter of a million
>> keys.
>>
>> David
>>
> Hi David,
>
> Thanks for the feedback.
>
> I can try to prototype that, but regardless of where the kernel buffer
> is allocated, the important part is causing the initial pagefault in the
> read path outside the lock so __put_user won't fail due to a valid user
> address but page backing the user address isn't in-core.
>
> I'll start work on v2.

Actually I'm going to back off on a v2 effort at this point and request
that folks comment on the code as-is. Changing keyctl_read_key to use
its own kernel buffer might be a worthwhile effort, but it doesn't
appear to me to have any effects on preventing pagefaults on user pages
at inopportune points of the code.

Thanks,

Chris

>
> Thanks,
>
> Chris
>


  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-18 18:40 Chris von Recklinghausen
2019-10-21 14:21 ` David Howells
2019-10-21 15:46   ` Chris von Recklinghausen
2019-10-25 11:10     ` Chris von Recklinghausen [this message]
2019-11-06 15:25       ` Chris von Recklinghausen
2019-10-21 15:47 ` Jarkko Sakkinen

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c87bfba-9dc9-665f-17e8-0656e87c658b@redhat.com \
    --to=crecklin@redhat.com \
    --cc=dhowells@redhat.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jmorris@namei.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=serge@hallyn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Security-Module Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-security-module/0 linux-security-module/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-security-module linux-security-module/ https://lore.kernel.org/linux-security-module \
		linux-security-module@vger.kernel.org
	public-inbox-index linux-security-module

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-security-module


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git