Linux-Security-Module Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] lsm: remove current_security()
@ 2019-09-04 23:00 Paul Moore
  2019-09-05  1:34 ` James Morris
  2019-09-09 15:58 ` Casey Schaufler
  0 siblings, 2 replies; 4+ messages in thread
From: Paul Moore @ 2019-09-04 23:00 UTC (permalink / raw)
  To: linux-security-module, selinux

There are no remaining callers and it really is unsafe in the brave
new world of LSM stacking.

Signed-off-by: Paul Moore <paul@paul-moore.com>
---
 include/linux/cred.h |    1 -
 1 file changed, 1 deletion(-)

diff --git a/include/linux/cred.h b/include/linux/cred.h
index efb6edf32de7..98b0a23ddd23 100644
--- a/include/linux/cred.h
+++ b/include/linux/cred.h
@@ -384,7 +384,6 @@ static inline void put_cred(const struct cred *_cred)
 #define current_fsgid() 	(current_cred_xxx(fsgid))
 #define current_cap()		(current_cred_xxx(cap_effective))
 #define current_user()		(current_cred_xxx(user))
-#define current_security()	(current_cred_xxx(security))
 
 extern struct user_namespace init_user_ns;
 #ifdef CONFIG_USER_NS


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] lsm: remove current_security()
  2019-09-04 23:00 [PATCH] lsm: remove current_security() Paul Moore
@ 2019-09-05  1:34 ` James Morris
  2019-09-05 20:26   ` Paul Moore
  2019-09-09 15:58 ` Casey Schaufler
  1 sibling, 1 reply; 4+ messages in thread
From: James Morris @ 2019-09-05  1:34 UTC (permalink / raw)
  To: Paul Moore; +Cc: linux-security-module, selinux

On Wed, 4 Sep 2019, Paul Moore wrote:

> There are no remaining callers and it really is unsafe in the brave
> new world of LSM stacking.
> 
> Signed-off-by: Paul Moore <paul@paul-moore.com>


Acked-by: James Morris <jamorris@linux.microsoft.com>

You might as well push this through with the SELinux changes.

-- 
James Morris
<jmorris@namei.org>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] lsm: remove current_security()
  2019-09-05  1:34 ` James Morris
@ 2019-09-05 20:26   ` Paul Moore
  0 siblings, 0 replies; 4+ messages in thread
From: Paul Moore @ 2019-09-05 20:26 UTC (permalink / raw)
  To: James Morris; +Cc: linux-security-module, selinux

On Wed, Sep 4, 2019 at 9:34 PM James Morris <jmorris@namei.org> wrote:
> On Wed, 4 Sep 2019, Paul Moore wrote:
>
> > There are no remaining callers and it really is unsafe in the brave
> > new world of LSM stacking.
> >
> > Signed-off-by: Paul Moore <paul@paul-moore.com>
>
> Acked-by: James Morris <jamorris@linux.microsoft.com>

Thanks.

> You might as well push this through with the SELinux changes.

That is what I was planning, it will break the build if merged via
another tree without Stephen's patch.  Merged into selinux/next to be
sent upstream during the next merge window.

-- 
paul moore
www.paul-moore.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] lsm: remove current_security()
  2019-09-04 23:00 [PATCH] lsm: remove current_security() Paul Moore
  2019-09-05  1:34 ` James Morris
@ 2019-09-09 15:58 ` Casey Schaufler
  1 sibling, 0 replies; 4+ messages in thread
From: Casey Schaufler @ 2019-09-09 15:58 UTC (permalink / raw)
  To: Paul Moore, linux-security-module, selinux

On 9/4/2019 4:00 PM, Paul Moore wrote:
> There are no remaining callers and it really is unsafe in the brave
> new world of LSM stacking.
>
> Signed-off-by: Paul Moore <paul@paul-moore.com>

Acked-by: Casey Schaufler <casey@schaufler-ca.com>

Thanks for this. It should have gone in with the last
set of stacking patches.

> ---
>  include/linux/cred.h |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/cred.h b/include/linux/cred.h
> index efb6edf32de7..98b0a23ddd23 100644
> --- a/include/linux/cred.h
> +++ b/include/linux/cred.h
> @@ -384,7 +384,6 @@ static inline void put_cred(const struct cred *_cred)
>  #define current_fsgid() 	(current_cred_xxx(fsgid))
>  #define current_cap()		(current_cred_xxx(cap_effective))
>  #define current_user()		(current_cred_xxx(user))
> -#define current_security()	(current_cred_xxx(security))
>  
>  extern struct user_namespace init_user_ns;
>  #ifdef CONFIG_USER_NS
>
>


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-04 23:00 [PATCH] lsm: remove current_security() Paul Moore
2019-09-05  1:34 ` James Morris
2019-09-05 20:26   ` Paul Moore
2019-09-09 15:58 ` Casey Schaufler

Linux-Security-Module Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-security-module/0 linux-security-module/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-security-module linux-security-module/ https://lore.kernel.org/linux-security-module \
		linux-security-module@vger.kernel.org linux-security-module@archiver.kernel.org
	public-inbox-index linux-security-module


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-security-module


AGPL code for this site: git clone https://public-inbox.org/ public-inbox