linux-security-module.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Casey Schaufler <casey@schaufler-ca.com>
To: Sabyrzhan Tasbolatov <snovitoll@gmail.com>
Cc: andreyknvl@google.com, jmorris@namei.org,
	linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org, mhocko@suse.com,
	penguin-kernel@i-love.sakura.ne.jp, serge@hallyn.com,
	syzbot+a71a442385a0b2815497@syzkaller.appspotmail.com,
	Casey Schaufler <casey@schaufler-ca.com>
Subject: Re: [PATCH v2] smackfs: restrict bytes count in smackfs write functions
Date: Tue, 2 Feb 2021 11:33:58 -0800	[thread overview]
Message-ID: <58e65f92-51ea-2dd0-d7b8-a63019e3dcf0@schaufler-ca.com> (raw)
In-Reply-To: <20210202191318.1402500-1-snovitoll@gmail.com>

On 2/2/2021 11:13 AM, Sabyrzhan Tasbolatov wrote:
>> if PAGE_SIZE >= SMK_LOADSIZE all legitimate requests can be made
>> using PAGE_SIZE as a limit. Your example with 19990 spaces before
>> the data demonstrates that the interface is inadequately documented.
>> Tizen and Automotive Grade Linux are going to be fine with a PAGE_SIZE
>> limit. The best way to address this concern is to go ahead with the
>> PAGE_SIZE limit and create ABI documents for the smackfs interfaces.
>> I will take your patch for the former and create a patch for the latter.
> Please let me know if there is anything else required for this patch.
> AFAIU, we agreed with PAGE_SIZE as the limit.

I am in the process of adding your patch to smack-next for 5.12.

I will have a separate documentation patch. 


      reply	other threads:[~2021-02-02 19:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-24 14:36 [PATCH] smackfs: restrict bytes count in smackfs write functions Sabyrzhan Tasbolatov
2021-01-25 18:08 ` Casey Schaufler
2021-01-25 22:42   ` Tetsuo Handa
2021-01-28 11:58     ` [PATCH v2] " Sabyrzhan Tasbolatov
2021-01-28 12:59       ` Tetsuo Handa
2021-01-28 13:27         ` Sabyrzhan Tasbolatov
2021-01-28 14:24           ` Tetsuo Handa
2021-01-29  2:10             ` Casey Schaufler
2021-02-02 19:13               ` Sabyrzhan Tasbolatov
2021-02-02 19:33                 ` Casey Schaufler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58e65f92-51ea-2dd0-d7b8-a63019e3dcf0@schaufler-ca.com \
    --to=casey@schaufler-ca.com \
    --cc=andreyknvl@google.com \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=mhocko@suse.com \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=serge@hallyn.com \
    --cc=snovitoll@gmail.com \
    --cc=syzbot+a71a442385a0b2815497@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).