Linux-Security-Module Archive on lore.kernel.org
 help / color / Atom feed
From: Mimi Zohar <zohar@linux.ibm.com>
To: Jarkko Sakkinen <jarkko@kernel.org>,
	Stefan Berger <stefanb@linux.ibm.com>
Cc: keyrings@vger.kernel.org, dhowells@redhat.com,
	nayna@linux.ibm.com, linux-integrity@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Add support for ECDSA-signed kernel modules
Date: Wed, 07 Apr 2021 12:10:04 -0400
Message-ID: <5a217256a53f9c33aba4528ab0393b84c42b1813.camel@linux.ibm.com> (raw)
In-Reply-To: <YG3Ve9CR0zZE+tUu@kernel.org>

On Wed, 2021-04-07 at 18:53 +0300, Jarkko Sakkinen wrote:
> On Tue, Apr 06, 2021 at 02:53:38PM -0400, Stefan Berger wrote:
> > This series adds support for ECDSA-signed kernel modules.
> > 
> > The first patch in this series attempts to address the issue where a
> > developer created an ECDSA key for signing modules and then falls back
> > to compiling an older version of the kernel that does not support
> > ECDSA keys. In this case this patch would delete that ECDSA key if it is
> > in certs/signing_key.pem and trigger the creation of an RSA key. However,
> > for this to work this patch would have to be applied to previous versions
> > of the kernel but would also only work for the developer if he/she used a
> > stable version of the kernel to which this patch was applied. So whether
> > this patch actually achieves the wanted effect is not always guaranteed.
> 
> Just wondering why the key needs to be removed in the fallback.

The main concern is with bisecting the kernel.  Either elliptic curve
support or the first patch needs to be backported.  This patch will
cause the kernel module signing key to be regenerated.

Mimi


  reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-06 18:53 Stefan Berger
2021-04-06 18:53 ` [PATCH 1/2] certs: Trigger recreation of module signing key if it's not an RSA key Stefan Berger
2021-04-06 18:53 ` [PATCH 2/2] certs: Add support for using elliptic curve keys for signing modules Stefan Berger
2021-04-07 15:53 ` [PATCH 0/2] Add support for ECDSA-signed kernel modules Jarkko Sakkinen
2021-04-07 16:10   ` Mimi Zohar [this message]
2021-04-07 17:53     ` Stefan Berger
2021-04-07 20:15       ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a217256a53f9c33aba4528ab0393b84c42b1813.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=dhowells@redhat.com \
    --cc=jarkko@kernel.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=nayna@linux.ibm.com \
    --cc=stefanb@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Security-Module Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-security-module/0 linux-security-module/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-security-module linux-security-module/ https://lore.kernel.org/linux-security-module \
		linux-security-module@vger.kernel.org
	public-inbox-index linux-security-module

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-security-module


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git