From: John Johansen <john.johansen@canonical.com>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: jmorris@namei.org, serge@hallyn.com, apparmor@lists.ubuntu.com,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] apparmor: Fix aa_str_perms() kernel-doc comment
Date: Thu, 19 May 2022 01:52:40 -0700 [thread overview]
Message-ID: <61824a01-0c03-7c74-1101-a30d3ae99f32@canonical.com> (raw)
In-Reply-To: <20220512075350.31163-1-yang.lee@linux.alibaba.com>
On 5/12/22 00:53, Yang Li wrote:
> Add the description of @start and remove @state in aa_str_perms()
> kernel-doc comment to remove warnings found by running scripts/kernel-doc,
> which is caused by using 'make W=1'.
>
> security/apparmor/file.c:260: warning: Function parameter or member
> 'start' not described in 'aa_str_perms'
> security/apparmor/file.c:260: warning: Excess function parameter 'state'
> description in 'aa_str_perms'
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
sorry, for the delay on this I have pulled it into my tree
Acked-by: John Johansen <john.johansen@canonical.com>
> ---
> security/apparmor/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/apparmor/file.c b/security/apparmor/file.c
> index e1b7e93602e4..137c99bb5d4a 100644
> --- a/security/apparmor/file.c
> +++ b/security/apparmor/file.c
> @@ -247,7 +247,7 @@ struct aa_perms aa_compute_fperms(struct aa_dfa *dfa, unsigned int state,
> /**
> * aa_str_perms - find permission that match @name
> * @dfa: to match against (MAYBE NULL)
> - * @state: state to start matching in
> + * @start: the state of the dfa to start matching in
> * @name: string to match against dfa (NOT NULL)
> * @cond: conditions to consider for permission set computation (NOT NULL)
> * @perms: Returns - the permissions found when matching @name
prev parent reply other threads:[~2022-05-19 8:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 7:53 [PATCH -next] apparmor: Fix aa_str_perms() kernel-doc comment Yang Li
2022-05-19 8:52 ` John Johansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61824a01-0c03-7c74-1101-a30d3ae99f32@canonical.com \
--to=john.johansen@canonical.com \
--cc=abaci@linux.alibaba.com \
--cc=apparmor@lists.ubuntu.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).