From: Mimi Zohar <zohar@linux.ibm.com>
To: Jonathan McDowell <noodles@fb.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-integrity@vger.kernel.org"
<linux-integrity@vger.kernel.org>,
"linux-security-module@vger.kernel.org"
<linux-security-module@vger.kernel.org>
Subject: Re: [PATCH v3] x86/kexec: Carry forward IMA measurement log on kexec
Date: Wed, 11 May 2022 13:53:23 -0400 [thread overview]
Message-ID: <67f0fe5874638241bc2f2401dc2bc12c51becc0b.camel@linux.ibm.com> (raw)
In-Reply-To: <YnuJCH75GrhVm0Tp@noodles-fedora.dhcp.thefacebook.com>
Hi Jonathan,
On Wed, 2022-05-11 at 09:59 +0000, Jonathan McDowell wrote:
> On kexec file load Integrity Measurement Architecture (IMA) subsystem
> may verify the IMA signature of the kernel and initramfs, and measure
> it. The command line parameters passed to the kernel in the kexec call
> may also be measured by IMA. A remote attestation service can verify
> a TPM quote based on the TPM event log, the IMA measurement list, and
> the TPM PCR data. This can be achieved only if the IMA measurement log
> is carried over from the current kernel to the next kernel across
> the kexec call.
>
> powerpc and ARM64 both achieve this using device tree with a
> "linux,ima-kexec-buffer" node. x86 platforms generally don't make use of
> device tree, so use the setup_data mechanism to pass the IMA buffer to
> the new kernel.
>
> Signed-off-by: Jonathan McDowell <noodles@fb.com>
> ---
> v3:
> - Rebase on tip/master
This patch doesn't apply to Linus' master branch. Which tip/master
branch? In the future, please use the git format-patch "--base=auto"
option.
> - Pull ima_(free|get)_kexec_buffer into x86 code
> - Push ifdefs into functions where possible
> - Reverse fir tree variable declarations
> - Fix section annotation on ima_free_kexec_buffer (__meminit)
> - Only allocate ima_setup_data space when IMA_KEXEC is enabled
IMA_KEXEC only controls whether the current measurement list should be
carried across kexec, not restoring the previous measurement list.
> v2:
> - Fix operation with EFI systems
> ---
> +++ b/include/linux/ima.h
> @@ -140,6 +140,9 @@ static inline int ima_measure_critical_data(const char *event_label,
>
> #endif /* CONFIG_IMA */
>
> +int ima_free_kexec_buffer(void);
> +int ima_get_kexec_buffer(void **addr, size_t *size);
Wouldn't moving these function definitions here imply they are
implemented on all architectures or are using the version in
drivers/of/kexec.c.
thanks,
Mimi
next prev parent reply other threads:[~2022-05-11 17:54 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 13:50 [PATCH] Carry forward IMA measurement log on kexec on x86_64 Jonathan McDowell
2022-04-25 16:29 ` Mimi Zohar
2022-04-26 12:08 ` Jonathan McDowell
2022-04-26 13:49 ` Mimi Zohar
2022-04-26 16:48 ` Jonathan McDowell
2022-04-26 18:10 ` Mimi Zohar
2022-04-28 10:40 ` Jonathan McDowell
2022-04-28 12:25 ` Mimi Zohar
2022-04-26 16:52 ` [PATCH v2] " Jonathan McDowell
2022-04-29 21:30 ` Mimi Zohar
2022-05-03 12:02 ` Jonathan McDowell
2022-05-04 13:49 ` Mimi Zohar
2022-05-09 10:40 ` Jonathan McDowell
2022-05-09 11:25 ` Boris Petkov
2022-05-09 17:46 ` Jonathan McDowell
2022-05-09 18:09 ` Borislav Petkov
2022-05-09 18:41 ` Jonathan McDowell
2022-05-09 19:40 ` Borislav Petkov
2022-05-10 8:02 ` Jonathan McDowell
2022-05-10 10:46 ` Borislav Petkov
2022-05-11 9:59 ` [PATCH v3] x86/kexec: Carry forward IMA measurement log on kexec Jonathan McDowell
2022-05-11 17:53 ` Mimi Zohar [this message]
2022-05-11 17:56 ` Borislav Petkov
2022-05-11 19:12 ` Mimi Zohar
2022-05-12 1:34 ` Mimi Zohar
2022-05-12 16:25 ` [PATCH v4] " Jonathan McDowell
2022-05-13 17:19 ` Lakshmi Ramasubramanian
2022-05-16 15:15 ` Jonathan McDowell
2022-05-17 17:19 ` Lakshmi Ramasubramanian
2022-05-18 10:42 ` Jonathan McDowell
2022-05-18 14:43 ` Mimi Zohar
2022-05-30 8:40 ` Jonathan McDowell
2022-06-03 15:55 ` Dave Hansen
2022-06-06 3:54 ` Baoquan He
2022-06-06 4:06 ` Baoquan He
2022-06-10 9:52 ` Jonathan McDowell
2022-06-13 10:30 ` [PATCH v5] " Jonathan McDowell
2022-06-13 21:01 ` Mimi Zohar
2022-06-16 2:59 ` Baoquan He
2022-06-16 15:30 ` [PATCH v6] " Jonathan McDowell
2022-06-30 8:36 ` [PATCH v7] " Jonathan McDowell
2022-06-30 11:54 ` Mimi Zohar
2022-07-04 2:36 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67f0fe5874638241bc2f2401dc2bc12c51becc0b.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=hpa@zytor.com \
--cc=jmorris@namei.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=noodles@fb.com \
--cc=serge@hallyn.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).