From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6005CC433E7 for ; Mon, 13 Jul 2020 20:32:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E44E2077D for ; Mon, 13 Jul 2020 20:32:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="cHdBGMUw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726767AbgGMUcx (ORCPT ); Mon, 13 Jul 2020 16:32:53 -0400 Received: from linux.microsoft.com ([13.77.154.182]:36770 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726150AbgGMUcw (ORCPT ); Mon, 13 Jul 2020 16:32:52 -0400 Received: from [10.0.0.249] (c-24-19-135-168.hsd1.wa.comcast.net [24.19.135.168]) by linux.microsoft.com (Postfix) with ESMTPSA id CAADF20B4909; Mon, 13 Jul 2020 13:32:50 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com CAADF20B4909 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1594672371; bh=VeWN4l0WTivLpVxHyd7AaFSTibjlEMzXV0jVP3Zo+E4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=cHdBGMUwa6d7vQELISebugbZOJJPgfylgs+Ow4juQxNZlH84Uew4znIMhI1ctPIqj H3I0N3rghH+OPS5b0/jhoIQBL8VUHOjGPpO6T+NSQaCMWJ5VU3jNPyjiJGtaOjHTVC 7dGIyN+NRs9Dp/ZrXQdYTJ5ocXPgoEQ4OChP6Zbc= Subject: Re: [V2 PATCH 2/3] dt-bindings: chosen: Document ima-kexec-buffer To: Thiago Jung Bauermann Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, robh+dt@kernel.org, frowand.list@gmail.com, zohar@linux.ibm.com, dmitry.kasatkin@gmail.com, jmorris@namei.org, serge@hallyn.com, pasha.tatashin@soleen.com, allison@lohutok.net, kstewart@linuxfoundation.org, takahiro.akashi@linaro.org, tglx@linutronix.de, vincenzo.frascino@arm.com, mark.rutland@arm.com, masahiroy@kernel.org, james.morse@arm.com, bhsharma@redhat.com, mbrugger@suse.com, hsinyi@chromium.org, tao.li@vivo.com, christophe.leroy@c-s.fr, gregkh@linuxfoundation.org, nramas@linux.microsoft.com, tusharsu@linux.microsoft.com, balajib@linux.microsoft.com References: <20200618071045.471131-1-prsriva@linux.microsoft.com> <20200618071045.471131-3-prsriva@linux.microsoft.com> <87mu4yr2k2.fsf@morokweng.localdomain> From: Prakhar Srivastava Message-ID: <80813a16-be43-3fc4-4812-33c60095a423@linux.microsoft.com> Date: Mon, 13 Jul 2020 13:32:50 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87mu4yr2k2.fsf@morokweng.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On 6/19/20 5:41 PM, Thiago Jung Bauermann wrote: > > Prakhar Srivastava writes: > >> Integrity measurement architecture(IMA) validates if files >> have been accidentally or maliciously altered, both remotely and >> locally, appraise a file's measurement against a "good" value stored >> as an extended attribute, and enforce local file integrity. >> >> IMA also measures singatures of kernel and initrd during kexec along with >> the command line used for kexec. >> These measurements are critical to verify the seccurity posture of the OS. >> >> Resering memory and adding the memory information to a device tree node >> acts as the mechanism to carry over IMA measurement logs. >> >> Update devicetree documentation to reflect the addition of new property >> under the chosen node. > > Thank you for writing this documentation patch. It's something I should > have done when I added the powerpc IMA kexec support. > > You addressed Rob Herring's comments regarding the commit message, but > not the ones regarding the patch contents. > > When posting a new version of the patches, make sure to address all > comments made so far. Addressing a comment doesn't necessarily mean > implementing the requested change. If you don't then you should at least > explain why you chose a different path. > > I mention it because this has occurred before with this patch series, > and it's hard to make forward progress if review comments get ignored. > >> --- >> Documentation/devicetree/bindings/chosen.txt | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/chosen.txt b/Documentation/devicetree/bindings/chosen.txt >> index 45e79172a646..a15f70c007ef 100644 >> --- a/Documentation/devicetree/bindings/chosen.txt >> +++ b/Documentation/devicetree/bindings/chosen.txt >> @@ -135,3 +135,20 @@ e.g. >> linux,initrd-end = <0x82800000>; >> }; >> }; >> + >> +linux,ima-kexec-buffer >> +---------------------- >> + >> +This property(currently used by powerpc, arm64) holds the memory range, > > space before the parenthesis. > >> +the address and the size, of the IMA measurement logs that are being carried > > Maybe it's because English isn't my first language, but IMHO it's > clearer if "the address and the size" is between parentheses rather than > commas. > >> +over to the kexec session. > > I don't think there's a "kexec session", but I'm not sure what a good > term would be. "linux,booted-from-kexec" uses "new kernel" so perhaps > that's a good option to use instead of "kexec session". > >> + >> +/ { >> + chosen { >> + linux,ima-kexec-buffer = <0x9 0x82000000 0x0 0x00008000>; >> + }; >> +}; >> + >> +This porperty does not represent real hardware, but the memory allocated for >> +carrying the IMA measurement logs. The address and the suze are expressed in >> +#address-cells and #size-cells, respectively of the root node. > > I will update the descriptions and ack the comments/changes in the patches as well. Thankyou, Prakhar Srivastava > -- > Thiago Jung Bauermann > IBM Linux Technology Center >