From: ebiederm@xmission.com (Eric W. Biederman)
To: Ondrej Mosnacek <omosnace@redhat.com>
Cc: Paul Moore <paul@paul-moore.com>,
selinux@vger.kernel.org,
Trond Myklebust <trond.myklebust@primarydata.com>,
Seth Forshee <seth.forshee@canonical.com>,
linux-fsdevel@vger.kernel.org,
Linux Security Module list
<linux-security-module@vger.kernel.org>
Subject: Re: [PATCH] selinux: always allow mounting submounts
Date: Wed, 28 Nov 2018 11:38:39 -0600 [thread overview]
Message-ID: <87efb5f6g0.fsf@xmission.com> (raw)
In-Reply-To: <CAFqZXNsxH2TMU-ZxxfzvqPcwQ9FzUj1N3iS-7AVQ3JZvj2KEYA@mail.gmail.com> (Ondrej Mosnacek's message of "Wed, 28 Nov 2018 17:12:00 +0100")
Ondrej Mosnacek <omosnace@redhat.com> writes:
> On Wed, Nov 28, 2018 at 4:42 PM Eric W. Biederman <ebiederm@xmission.com> wrote:
>>
>> A few late comments on this.
>>
>> The change mentioned in fixes did not remove a SB_KERNMOUNT so I don't
>> see how it is a fix for that. That change just added SB_SUBMOUNT so you
>> can test for and detect this situation. Are you seeing something that I
>> am not in that change?
>
> No, you're right that this patch doesn't "fix" that commit in the
> usual sense (the bug has pretty much always been there). However, that
> commit is the one that introduces the SB_KERNMOUNT flag and thus this
> patch can be only applied on trees that have that commit. That's what
> I tried to communicate with the "Fixes:" tag. Maybe I abused it a
> little, but it is often used to guide backporting so I figured it
> would make sense like this.
That makes sense. In cases like that I use Ref: instead of Fixes:
That makes the connection clear, without implying the other patch was
wrong.
That and I would say something like. It is now possible to fix this
as submounts are not detectable. Or something like that.
Eric
prev parent reply other threads:[~2018-11-28 17:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181116131202.26513-1-omosnace@redhat.com>
[not found] ` <CAHC9VhTn9qz77PQ3mboaCsNzK9D8hjYFg9z5sCWr8Yb7W2Pqxg@mail.gmail.com>
[not found] ` <CAFqZXNsAHnV5RzwtONF0hJRy31qb4c=sajvaEkmEjjky4duEBA@mail.gmail.com>
[not found] ` <CAFqZXNvSdKYr998v3hEhZu4pRwuQs8Q7qRWPhOAtLAc9__Bs6w@mail.gmail.com>
[not found] ` <CAHC9VhTvuPvnkfgQhT4+AM3iEz4_p85QgShM_oXmpVtLKuq10Q@mail.gmail.com>
2018-11-28 15:40 ` [PATCH] selinux: always allow mounting submounts Eric W. Biederman
2018-11-28 16:12 ` Ondrej Mosnacek
2018-11-28 17:38 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efb5f6g0.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=omosnace@redhat.com \
--cc=paul@paul-moore.com \
--cc=selinux@vger.kernel.org \
--cc=seth.forshee@canonical.com \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).