From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0A74C433E0 for ; Wed, 1 Jul 2020 17:23:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C94BC20771 for ; Wed, 1 Jul 2020 17:23:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732632AbgGARXT (ORCPT ); Wed, 1 Jul 2020 13:23:19 -0400 Received: from out02.mta.xmission.com ([166.70.13.232]:59228 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726432AbgGARXT (ORCPT ); Wed, 1 Jul 2020 13:23:19 -0400 Received: from in01.mta.xmission.com ([166.70.13.51]) by out02.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jqgS1-0004UG-IT; Wed, 01 Jul 2020 11:23:13 -0600 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95] helo=x220.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1jqgS0-0002b1-HA; Wed, 01 Jul 2020 11:23:13 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: Linus Torvalds Cc: Linux Kernel Mailing List , David Miller , Greg Kroah-Hartman , Tetsuo Handa , Alexei Starovoitov , Kees Cook , Andrew Morton , Alexei Starovoitov , Al Viro , bpf , linux-fsdevel , Daniel Borkmann , Jakub Kicinski , Masahiro Yamada , Gary Lin , Bruno Meneguele , LSM List , Casey Schaufler , Luis Chamberlain References: <20200625095725.GA3303921@kroah.com> <778297d2-512a-8361-cf05-42d9379e6977@i-love.sakura.ne.jp> <20200625120725.GA3493334@kroah.com> <20200625.123437.2219826613137938086.davem@davemloft.net> <87pn9mgfc2.fsf_-_@x220.int.ebiederm.org> <87y2oac50p.fsf@x220.int.ebiederm.org> <87bll17ili.fsf_-_@x220.int.ebiederm.org> <87imf963s6.fsf_-_@x220.int.ebiederm.org> Date: Wed, 01 Jul 2020 12:18:38 -0500 In-Reply-To: (Linus Torvalds's message of "Tue, 30 Jun 2020 09:58:47 -0700") Message-ID: <87ftabw3v5.fsf@x220.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1jqgS0-0002b1-HA;;;mid=<87ftabw3v5.fsf@x220.int.ebiederm.org>;;;hst=in01.mta.xmission.com;;;ip=68.227.160.95;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX19t9X1hgcG3oTWl30nEiWfbVh/quO6qF7U= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH v2 05/15] umh: Separate the user mode driver and the user mode helper support X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: Archived-At: List-Archive: List-Post: Linus Torvalds writes: > On Mon, Jun 29, 2020 at 1:05 PM Eric W. Biederman wrote: >> >> This makes it clear which code is part of the core user mode >> helper support and which code is needed to implement user mode >> drivers. >> >> kernel/umd.c | 146 +++++++++++++++++++++++++++++++++++++++ >> kernel/umh.c | 139 ------------------------------------- > > I certainly don't object to the split, but I hate the name. > > We have uml, umd and umh for user mode {linux, drivers, helper} > respectively.And honestly, I don't see the point in using an obscure > and unreadable TLA for something like this. > > I really don't think it would hurt to write out even the full name > with "usermode_driver.c" or something like that, would it? > > Then "umd" could be continued to be used as a prefix for the helper > functions, by all means, but if we startv renaming files, can we do it > properly? I will take care of it. I have to respin the patchset for a silly bug anyways. Eric