From: ebiederm@xmission.com (Eric W. Biederman)
To: Alexey Gladkov <gladkov.alexey@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
syzbot <syzbot+c1af344512918c61362c@syzkaller.appspotmail.com>,
jmorris@namei.org, linux-next@vger.kernel.org,
linux-security-module@vger.kernel.org, serge@hallyn.com,
sfr@canb.auug.org.au, syzkaller-bugs@googlegroups.com,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v2] proc: proc_pid_ns takes super_block as an argument
Date: Mon, 18 May 2020 07:57:16 -0500 [thread overview]
Message-ID: <87pnb15rkj.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <20200518125648.robgr7mud7esao2o@comp-core-i7-2640m-0182e6> (Alexey Gladkov's message of "Mon, 18 May 2020 14:56:48 +0200")
Alexey Gladkov <gladkov.alexey@gmail.com> writes:
> On Mon, May 18, 2020 at 07:08:57AM -0500, Eric W. Biederman wrote:
>> Alexey Gladkov <gladkov.alexey@gmail.com> writes:
>>
>> > The proc_pid_ns() can be used for both inode and dentry. To avoid making
>> > two identical functions, change the argument type of the proc_pid_ns().
>> >
>> > Link: https://lore.kernel.org/lkml/c3461e26-1407-2262-c709-dac0df3da2d0@i-love.sakura.ne.jp/
>> > Reported-by: syzbot+c1af344512918c61362c@syzkaller.appspotmail.com
>> > Signed-off-by: Alexey Gladkov <gladkov.alexey@gmail.com>
>>
>> So overall this looks good.
>>
>> However, the description leaves a little bit to be desired as it does
>> not describe why it is bad to use dentry->d_sb. A fixes tag would be
>> nice if for no other reason than to help anyone who decides to backport
>> this.
>
> OK. I will add it.
Thank you. It really helps to have the full description of why in
the commit comments.
>> And can you please compile test this?
>>
>> There is a very silly typo in proc that keeps this from compiling.
>
> I compiled the kernel with this patch and ran the kernel, but accidentally
> did not check children_seq_show(). Sorry.
Yes, children_seq_show is behind a sneaky CONFIG option.
Eric
next prev parent reply other threads:[~2020-05-18 13:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 14:46 linux-next boot error: general protection fault in tomoyo_get_local_path syzbot
2020-05-15 15:18 ` Tetsuo Handa
2020-05-15 15:36 ` Tetsuo Handa
2020-05-15 20:13 ` Al Viro
2020-05-15 20:36 ` Eric W. Biederman
2020-05-15 20:56 ` Al Viro
2020-05-15 18:16 ` Eric W. Biederman
2020-05-15 19:25 ` Alexey Gladkov
2020-05-17 17:11 ` [PATCH] proc: proc_pid_ns takes super_block as an argument Alexey Gladkov
2020-05-18 11:17 ` [PATCH v2] " Alexey Gladkov
2020-05-18 12:08 ` Eric W. Biederman
2020-05-18 12:56 ` Alexey Gladkov
2020-05-18 12:57 ` Eric W. Biederman [this message]
2020-05-18 15:08 ` [PATCH v3] " Alexey Gladkov
2020-05-18 15:36 ` Tetsuo Handa
2020-05-18 18:07 ` [PATCH v4] " Alexey Gladkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnb15rkj.fsf@x220.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=gladkov.alexey@gmail.com \
--cc=jmorris@namei.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=serge@hallyn.com \
--cc=sfr@canb.auug.org.au \
--cc=syzbot+c1af344512918c61362c@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).