From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A022C169C4 for ; Fri, 8 Feb 2019 12:23:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 11F74206BA for ; Fri, 8 Feb 2019 12:23:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726679AbfBHMW4 (ORCPT ); Fri, 8 Feb 2019 07:22:56 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:48030 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726456AbfBHMWz (ORCPT ); Fri, 8 Feb 2019 07:22:55 -0500 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x18CFtJ8069970 for ; Fri, 8 Feb 2019 07:22:54 -0500 Received: from e12.ny.us.ibm.com (e12.ny.us.ibm.com [129.33.205.202]) by mx0a-001b2d01.pphosted.com with ESMTP id 2qh8ewunc2-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 08 Feb 2019 07:22:54 -0500 Received: from localhost by e12.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 8 Feb 2019 12:22:53 -0000 Received: from b01cxnp23033.gho.pok.ibm.com (9.57.198.28) by e12.ny.us.ibm.com (146.89.104.199) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 8 Feb 2019 12:22:49 -0000 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x18CMmEb23527602 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 8 Feb 2019 12:22:48 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D6EF9124055; Fri, 8 Feb 2019 12:22:48 +0000 (GMT) Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C2D79124053; Fri, 8 Feb 2019 12:22:48 +0000 (GMT) Received: from sbct-3.pok.ibm.com (unknown [9.47.158.153]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP; Fri, 8 Feb 2019 12:22:48 +0000 (GMT) Subject: Re: [PATCH v11 00/16] Remove nested TPM operations To: Jarkko Sakkinen Cc: Alexander Steffen , linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, Peter Huewe , Jason Gunthorpe , Tomas Winkler , Tadeusz Struk , Stefan Berger , Nayna Jain References: <20190205224723.19671-1-jarkko.sakkinen@linux.intel.com> <20190206120634.GA4680@linux.intel.com> <3d6fdcc1-8221-2137-fc82-596377cc2fdc@infineon.com> <20190207212912.GD23906@linux.intel.com> <0af40351-91d5-d0a7-2965-0a9c6505af79@linux.ibm.com> <20190208003314.GB7202@linux.intel.com> <1fbd29ad-1005-8450-4c39-00974468183b@linux.ibm.com> <9cd734ad-ea9d-77f7-b657-3f0910a9d92f@linux.ibm.com> <20190208115031.GB11755@linux.intel.com> From: Stefan Berger Date: Fri, 8 Feb 2019 07:22:48 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <20190208115031.GB11755@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-MW X-TM-AS-GCONF: 00 x-cbid: 19020812-0060-0000-0000-00000307F811 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00010558; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000279; SDB=6.01158065; UDB=6.00604223; IPR=6.00938597; MB=3.00025494; MTD=3.00000008; XFM=3.00000015; UTC=2019-02-08 12:22:52 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19020812-0061-0000-0000-0000483A1ABA Message-Id: <8aecea14-cf0a-da6b-305c-c61ae03214be@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-02-08_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902080088 Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On 2/8/19 6:50 AM, Jarkko Sakkinen wrote: > On Thu, Feb 07, 2019 at 09:14:54PM -0500, Stefan Berger wrote: > >>      chip->ops = NULL; >>      up_write(&chip->ops_sem); >>  } >> diff --git a/drivers/char/tpm/tpm-interface.c >> b/drivers/char/tpm/tpm-interface.c >> index 02e8cffd1163..fcd845ad8c3c 100644 >> --- a/drivers/char/tpm/tpm-interface.c >> +++ b/drivers/char/tpm/tpm-interface.c >> @@ -124,6 +124,8 @@ static ssize_t tpm_try_transmit(struct tpm_chip *chip, >> void *buf, size_t bufsiz) >>          dev_err(&chip->dev, "tpm_transmit: tpm_recv: error %d\n", rc); >>      } else if (len < TPM_HEADER_SIZE || len != be32_to_cpu(header->length)) >>          rc = -EFAULT; >> +    else >> +        rc = 0; > Why is this needed? Because it holds a non-zero value, which is wrong at this point. Below it is: return rc ? rc : len; It will always return that rc and never 'len'. It's not just needed for bisecting. I still need it with your latest tree. That's the only change I need with my current testing of tpm_vtpm_proxy, TIS + TPM 1.2 , TIS + TPM 2.0 , and CRB + TPM 2.0 (with QEMU :-) ).    Stefan