From: Stuart Yoder <stuart.yoder@arm.com>
To: Sumit Garg <sumit.garg@linaro.org>,
keyrings@vger.kernel.org, linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org
Cc: tee-dev@lists.linaro.org, daniel.thompson@linaro.org,
corbet@lwn.net, jejb@linux.ibm.com, ard.biesheuvel@linaro.org,
linux-doc@vger.kernel.org, zohar@linux.ibm.com,
linux-kernel@vger.kernel.org, dhowells@redhat.com,
jarkko.sakkinen@linux.intel.com, casey@schaufler-ca.com,
linux-arm-kernel@lists.infradead.org, serge@hallyn.com
Subject: Re: [Tee-dev] [RFC v2 2/6] tee: enable support to register kernel memory
Date: Thu, 8 Aug 2019 17:26:58 -0500 [thread overview]
Message-ID: <99777010-db74-096a-ce1a-da30539d6fb5@arm.com> (raw)
In-Reply-To: <1564489420-677-3-git-send-email-sumit.garg@linaro.org>
On 7/30/19 7:23 AM, Sumit Garg wrote:
> @@ -264,7 +266,17 @@ struct tee_shm *tee_shm_register(struct tee_context *ctx, unsigned long addr,
> goto err;
> }
>
> - rc = get_user_pages_fast(start, num_pages, FOLL_WRITE, shm->pages);
> + if (flags & TEE_SHM_USER_MAPPED) {
> + rc = get_user_pages_fast(start, num_pages, FOLL_WRITE,
> + shm->pages);
> + } else {
> + const struct kvec kiov = {
> + .iov_base = (void *)start,
> + .iov_len = PAGE_SIZE
> + };
> +
> + rc = get_kernel_pages(&kiov, num_pages, 0, shm->pages);
Passing a single kvec struct is temporary I assume? Because as currently
written this will only work with num_pages==1.
Stuart
next prev parent reply other threads:[~2019-08-08 22:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 12:23 [RFC v2 0/6] Introduce TEE based Trusted Keys support Sumit Garg
2019-07-30 12:23 ` [RFC v2 1/6] tee: optee: allow kernel pages to register as shm Sumit Garg
2019-07-30 12:23 ` [RFC v2 2/6] tee: enable support to register kernel memory Sumit Garg
2019-08-08 22:26 ` Stuart Yoder [this message]
2019-08-09 5:36 ` [Tee-dev] " Sumit Garg
2019-07-30 12:23 ` [RFC v2 3/6] tee: add private login method for kernel clients Sumit Garg
2019-07-30 12:23 ` [RFC v2 4/6] KEYS: trusted: Introduce TEE based Trusted Keys Sumit Garg
2019-07-30 12:23 ` [RFC v2 5/6] doc: keys: Document usage of " Sumit Garg
2019-07-30 12:23 ` [RFC v2 6/6] MAINTAINERS: Add entry for " Sumit Garg
2019-07-31 7:11 ` [RFC v2 0/6] Introduce TEE based Trusted Keys support Janne Karhunen
2019-07-31 10:21 ` Janne Karhunen
2019-07-31 13:58 ` Sumit Garg
2019-08-01 6:21 ` Janne Karhunen
2019-08-01 7:40 ` Sumit Garg
2019-08-01 7:59 ` Janne Karhunen
2019-08-01 10:00 ` Sumit Garg
2019-08-01 10:40 ` Janne Karhunen
2019-07-31 10:26 ` Sumit Garg
2019-07-31 11:02 ` Janne Karhunen
2019-07-31 14:23 ` Sumit Garg
2019-08-01 6:36 ` Janne Karhunen
2019-08-01 6:50 ` [Tee-dev] " Rouven Czerwinski
2019-08-01 7:30 ` Janne Karhunen
2019-08-01 7:58 ` Sumit Garg
2019-08-01 8:30 ` Janne Karhunen
2019-08-01 10:27 ` Sumit Garg
2019-08-04 20:48 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99777010-db74-096a-ce1a-da30539d6fb5@arm.com \
--to=stuart.yoder@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=casey@schaufler-ca.com \
--cc=corbet@lwn.net \
--cc=daniel.thompson@linaro.org \
--cc=dhowells@redhat.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jejb@linux.ibm.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=sumit.garg@linaro.org \
--cc=tee-dev@lists.linaro.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).