From: KP Singh <kpsingh@chromium.org>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: open list <linux-kernel@vger.kernel.org>,
Linux Security Module list
<linux-security-module@vger.kernel.org>,
Florent Revest <revest@chromium.org>,
James Morris <jmorris@namei.org>,
Kees Cook <keescook@chromium.org>,
Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
Jann Horn <jannh@google.com>
Subject: Re: [PATCH v2] ima: Fix NULL pointer dereference in ima_file_hash
Date: Wed, 16 Sep 2020 18:59:25 +0200 [thread overview]
Message-ID: <CACYkzJ4C4mLZY0=Z_BHc+0u0oCuCu0xkYdUPCp=Xs12uT7175w@mail.gmail.com> (raw)
In-Reply-To: <8cee070eed5b8a3dc9f373fc9db8d99a70b7d75a.camel@linux.ibm.com>
On Wed, Sep 16, 2020 at 6:00 PM Mimi Zohar <zohar@linux.ibm.com> wrote:
>
> On Wed, 2020-09-16 at 14:49 +0200, KP Singh wrote:
> > From: KP Singh <kpsingh@google.com>
> >
> > ima_file_hash can be called when there is no iint->ima_hash available
> > even though the inode exists in the integrity cache.
> >
> > An example where this can happen (suggested by Jann Horn):
> >
> > Process A does:
> >
> > while(1) {
> > unlink("/tmp/imafoo");
> > fd = open("/tmp/imafoo", O_RDWR|O_CREAT|O_TRUNC, 0700);
> > if (fd == -1) {
> > perror("open");
> > continue;
> > }
> > write(fd, "A", 1);
> > close(fd);
> > }
> >
> > and Process B does:
> >
> > while (1) {
> > int fd = open("/tmp/imafoo", O_RDONLY);
> > if (fd == -1)
> > continue;
> > char *mapping = mmap(NULL, 0x1000, PROT_READ|PROT_EXEC,
> > MAP_PRIVATE, fd, 0);
> > if (mapping != MAP_FAILED)
> > munmap(mapping, 0x1000);
> > close(fd);
> > }
> >
> > Due to the race to get the iint->mutex between ima_file_hash and
> > process_measurement iint->ima_hash could still be NULL.
> >
> > Fixes: 6beea7afcc72 ("ima: add the ability to query the cached hash of a given file")
> > Signed-off-by: KP Singh <kpsingh@google.com>
> > Reviewed-by: Florent Revest <revest@chromium.org>
> > ---
> > security/integrity/ima/ima_main.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
> > index 8a91711ca79b..4c86cd4eece0 100644
> > --- a/security/integrity/ima/ima_main.c
> > +++ b/security/integrity/ima/ima_main.c
> > @@ -531,6 +531,16 @@ int ima_file_hash(struct file *file, char *buf, size_t buf_size)
> > return -EOPNOTSUPP;
> >
> > mutex_lock(&iint->mutex);
> > +
> > + /*
> > + * ima_file_hash can be called when ima_collect_measurement has still
> > + * not been called, we might not always have a hash.
> > + */
> > + if (!iint->ima_hash) {
> > + mutex_unlock(&iint->mutex);
> > + return -EOPNOTSUPP;
> > + }
> > +
>
> Not having a file hash is rather common (e.g. mknodat, prior to the
> file being closed). Before appraising the integrity of a file, it
> checks whether it is a new file (eg. IMA_NEW_FILE), but, unfortunately,
> the flag is only set for those files in the appraise policy.
Makes sense.
>
> The patch looks fine, but you might want to reflect not having a file
> hash is common in the patch description.
>
Thanks! Will send another revision with an updated description.
- KP
> Mimi
>
> > if (buf) {
> > size_t copied_size;
> >
>
>
prev parent reply other threads:[~2020-09-16 19:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 12:49 [PATCH v2] ima: Fix NULL pointer dereference in ima_file_hash KP Singh
2020-09-16 13:36 ` KP Singh
2020-09-16 16:00 ` Mimi Zohar
2020-09-16 16:59 ` KP Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACYkzJ4C4mLZY0=Z_BHc+0u0oCuCu0xkYdUPCp=Xs12uT7175w@mail.gmail.com' \
--to=kpsingh@chromium.org \
--cc=jannh@google.com \
--cc=jmorris@namei.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nramas@linux.microsoft.com \
--cc=revest@chromium.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).