From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E5FCC3A59E for ; Tue, 20 Aug 2019 05:52:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5219E2087E for ; Tue, 20 Aug 2019 05:52:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HQvqSgy0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729150AbfHTFwT (ORCPT ); Tue, 20 Aug 2019 01:52:19 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:36007 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729091AbfHTFwT (ORCPT ); Tue, 20 Aug 2019 01:52:19 -0400 Received: by mail-lf1-f68.google.com with SMTP id j17so3146862lfp.3 for ; Mon, 19 Aug 2019 22:52:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vHAQ6sjGHaPokXl9LscA2e05lIoVzw0cNrU4ejp7cLc=; b=HQvqSgy0YUzEMHBgIvYKX0zsNdO2GK/OgcaAI+Yo+QEFURl36YFnDm6QxkYKZLBQfh gl6kpBN477j29o3jAxsyCKqzbbwiKtO8wwumBKw+Fy5bbzHiHTBdZo9vYs2WUaOUFk5C rfgG0y2dLA/qprCRRnLVrD/nZCVXNgya8cNMMDFfIrGMmj5v5uPhthv3gH/tTj9zqGt7 2WtXPOqYS6+/elBcXC2Ff66xH3qX8e3ZFThDI6neMyANPzJYKkoNUZUTl+uQUPJQXGYK 4pORYYX1dPk/YoJ4PVlrOLRxRF6rtiz5mSvpWxKyh+0Fln7DLrG08nF45fRRUJpa5Dg0 qS/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vHAQ6sjGHaPokXl9LscA2e05lIoVzw0cNrU4ejp7cLc=; b=E2PkELMdY9tgKQSdaZWTrLjK2jNAiZlrEizveVd+MHv5em8EPStDbjiTaZpDxRtzpT 67FaRmI+k1uT5p6Yayfmftb6iZukZA41Y95WgqNJ7FR2TAkKHdTbITXpEndof6vcGNGj py8PGt1xTHbxwoEgooNZB+AcC2lVdDU1+1Ownd/kYAcLRMHIc8pEOTxL5xx1FQzJOzJQ r0nOYzErDewue0kspCsWSavWMG713ZPhK9vQhhA+aGtTxEfGZ4e/Pb/lDzGkA1d/otbi FB/uTPj6XVRDzS9VTihkuMFEqjUYiEdu5VDMVA+6CYLO6fkLNTXVHkkNXg8bJ2aSjl1Q +K4Q== X-Gm-Message-State: APjAAAWtPM//WvB59XXCT1gGr3cw/mnnt9HMFYBf2m6ty4XP151ZksLM e72BIAOVPWcJMAFoaHoRAvTxafbgUSzF0Z4kXRL2aQ== X-Google-Smtp-Source: APXvYqw5VQhpvfJxXd2kxR0GMuYrecMAqIEichsfrIuwkJJya9Bt9H2v7Gsuv+lSVTPHE4s9++DwaiSgqwaVMZmC/x4= X-Received: by 2002:ac2:4901:: with SMTP id n1mr14221485lfi.0.1566280337317; Mon, 19 Aug 2019 22:52:17 -0700 (PDT) MIME-Version: 1.0 References: <1565682784-10234-1-git-send-email-sumit.garg@linaro.org> <1565682784-10234-2-git-send-email-sumit.garg@linaro.org> <20190819165629.qv7cmg6kiwb6oxig@linux.intel.com> In-Reply-To: <20190819165629.qv7cmg6kiwb6oxig@linux.intel.com> From: Sumit Garg Date: Tue, 20 Aug 2019 11:22:05 +0530 Message-ID: Subject: Re: [RFC/RFT v4 1/5] tpm: move tpm_buf code to include/linux/ To: Jarkko Sakkinen Cc: keyrings@vger.kernel.org, linux-integrity@vger.kernel.org, "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , linux-security-module@vger.kernel.org, dhowells@redhat.com, Herbert Xu , davem@davemloft.net, peterhuewe@gmx.de, jgg@ziepe.ca, jejb@linux.ibm.com, Arnd Bergmann , Greg Kroah-Hartman , Mimi Zohar , James Morris , "Serge E. Hallyn" , Casey Schaufler , Ard Biesheuvel , Daniel Thompson , Linux Kernel Mailing List , "tee-dev @ lists . linaro . org" Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Mon, 19 Aug 2019 at 22:26, Jarkko Sakkinen wrote: > > On Tue, Aug 13, 2019 at 01:23:00PM +0530, Sumit Garg wrote: > > Move tpm_buf code to common include/linux/tpm.h header so that it can > > be reused via other subsystems like trusted keys etc. > > > > Also rename trusted keys TPM 1.x buffer implementation to tpm1_buf to > > avoid any compilation errors. > > > > Suggested-by: Jarkko Sakkinen > > Signed-off-by: Sumit Garg > > A question: did you try to do this as mechanically as you ever could > or did you do any other code changes? I did go through it but it is > possible that I missed something. > There aren't any other code changes apart from "tpm1_buf" rename. -Sumit > In this type of changes it is mandatory be extra strict on not doing > anything extra (the rename you would was not of course extra because > it was necessary to do). > > /Jarkko