From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BEEBC4332D for ; Wed, 17 Mar 2021 07:41:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F39D664FAC for ; Wed, 17 Mar 2021 07:41:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229978AbhCQHk3 (ORCPT ); Wed, 17 Mar 2021 03:40:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230021AbhCQHkR (ORCPT ); Wed, 17 Mar 2021 03:40:17 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73408C061764 for ; Wed, 17 Mar 2021 00:40:06 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id s17so1940153ljc.5 for ; Wed, 17 Mar 2021 00:40:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iObzIxFvftTdKH1/yXifJjIJYlGMiIva4oZnIqTHzmM=; b=ZX9iixsaVwsqr/Cn1A2WeoWoFrumH7sNtxSYawUL91Lphse0MaPfjacqjM1FDqo5NV bAiKDQJaSGz8eQYBN13LKfX3quYfLXHo06AKoEXrU/lwTNqcjKeZJITR936O79VQUhI6 wobMISUTMmR4vRvl+SKxW9AWPCf4zKqBsL+w/IbYyVN/yTUpMOLeId+WA+mlkBmeuAfT SR6z4Mx3EcIwnv9OPgV9OMrbBmDQxsgYRPycRLcC3dtH0VHkmwD+z9Zc6xICnfWyuCGQ b3W1JCznoQqe9WgRzA4SyoIn3U+7fBtfqpAO6ndTTp+GB7kTenXE1vAdmc5JnfW18Ni6 Usog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iObzIxFvftTdKH1/yXifJjIJYlGMiIva4oZnIqTHzmM=; b=rDt4+Et0nWht+vLhprfTCFBC0JYwnTKhe8wG/cpStbaioUfV3b/PkGCCPQXsZneKDi hQOkWdgrLSCthLZsI3Hu/rs1iM5rHhu+Z6smoafcr9wtXSSw/1wy6S3bp3sgTPNvsi/9 0ryuaX539R02FsgZbIGAd2BM63hbi7bKNqwWbD0wO4sYNh7QmkWfx2GMsLp7RvBMW+ay WYL41YAVTT5O5hJ15W5dET8/NTIwHRGS87sAWnQ2RanT1FO4WlYXVg2Qypb6XKh8ldTp yEMKVqSLWQuKDCqFWvyru8WiVuJWExOibhaJ60bUJpFiAIYKbH+lrwRSgobMK6gkdYOh ATpw== X-Gm-Message-State: AOAM531NFPQkamzsIGSlFRIhTDEYEqDIHxN0W5J9S56qY/rT3qkwTzgk Gyl78BOsvR4QxPRGjwGfWb5s9NUgn011V1Dit+Gt4g== X-Google-Smtp-Source: ABdhPJxkZg9XDXYoY6hqQYdLLQExVMsp4ITka98+Ps8S1hFlsNeIPJBrvg4kY7aeSo/+tIGP5LduAXhwxBknckTLNck= X-Received: by 2002:a05:651c:481:: with SMTP id s1mr1539339ljc.152.1615966804665; Wed, 17 Mar 2021 00:40:04 -0700 (PDT) MIME-Version: 1.0 References: <319e558e1bd19b80ad6447c167a2c3942bdafea2.1615914058.git-series.a.fatoum@pengutronix.de> In-Reply-To: From: Sumit Garg Date: Wed, 17 Mar 2021 13:09:53 +0530 Message-ID: Subject: Re: [PATCH v1 3/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys To: Richard Weinberger Cc: Ahmad Fatoum , Jonathan Corbet , David Howells , Jarkko Sakkinen , James Bottomley , Mimi Zohar , kernel@pengutronix.de, James Morris , "Serge E. Hallyn" , =?UTF-8?Q?Horia_Geant=C4=83?= , Aymen Sghaier , Herbert Xu , "David S. Miller" , Udit Agarwal , Jan Luebbe , David Gstir , Franck LENORMAND , "open list:ASYMMETRIC KEYS" , Linux Crypto Mailing List , Linux Doc Mailing List , linux-integrity@vger.kernel.org, LKML , LSM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: Hi Richard, On Wed, 17 Mar 2021 at 04:45, Richard Weinberger wrote: > > Ahmad, > > On Tue, Mar 16, 2021 at 6:24 PM Ahmad Fatoum wrote: > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +struct caam_blob_priv *blobifier; > > Who is using this pointer too? > Otherwise I'd suggest marking it static. > > > module_param_named(source, trusted_key_source, charp, 0); > > -MODULE_PARM_DESC(source, "Select trusted keys source (tpm or tee)"); > > +MODULE_PARM_DESC(source, "Select trusted keys source (tpm, tee or caam)"); > > I didn't closely follow the previous discussions, but is a module > parameter really the right approach? > Is there also a way to set it via something like device tree? > It's there to support a platform which possesses multiple trusted keys backends. So that a user is able to select during boot which one to use as a backend. -Sumit > -- > Thanks, > //richard