From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21287C433DF for ; Tue, 2 Jun 2020 08:40:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0458420738 for ; Tue, 2 Jun 2020 08:40:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DaRRRUXP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726351AbgFBIkv (ORCPT ); Tue, 2 Jun 2020 04:40:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726320AbgFBIkv (ORCPT ); Tue, 2 Jun 2020 04:40:51 -0400 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BBFCC08C5C0 for ; Tue, 2 Jun 2020 01:40:50 -0700 (PDT) Received: by mail-lj1-x242.google.com with SMTP id a25so11580251ljp.3 for ; Tue, 02 Jun 2020 01:40:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ba7tS1EJd6J4rrFJlCgFQCMg5mXZk8lm0TUhKeqkFLg=; b=DaRRRUXPe+h4lT7HKYjlwOZPLtpKjj5wrJfc7A/FfABHr7pqA6sBVcDxFpYhyNGX2f mhQciVg9mJcl5lbwYvIUHYTLOz+H/JseFNTfhgEH1PUTCmGJfi2vmR2tmRbnXSyFTDE4 w4eCcHJwLE+Jelj9ifdDTlnu0lIKZx10kGWKP+LOH+aLlwER7WRXA5g20mnYOxnaNwWm 3M56FsBpyAAfxXgbKJti+9pbhLY8t86m4/VdbDv6kUVoyahF+iMYkTHJDo4u8M+83rUy MafhdMblZid34Foa6n+p2WuWVyEuwMjkPZdBGHlFOS0Ezjf8cSGe7D1etislzBDLC4++ g6iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ba7tS1EJd6J4rrFJlCgFQCMg5mXZk8lm0TUhKeqkFLg=; b=DsYKk3MH1jIzzrWUwdX82iSs3tuuL/1dTkow+0ItmOHsWpWVl7u4UMO5C/1lsYpvGn DC026tWrWGvyqfot27Tfw2TGuDGwHABM9ZI34L4r7ga4YWmwSMCVLQcZm164ybjOy81G 4chlqH0E8ouxfW2o5ZZirDfuxB3Kz4m4MICi3xfKsg1j215XPLWCj/aOo8IHmZPKmV4o X3wH8Y9OcfjEreeFBmO16ZaPk4N2GEtEN23IPQLdguYa0fcXhO1fvqdB2qXGNbWvpN7L HCMPud2JYXEcW2bD+AZKL6vx2LW+JKd5lhW3BD+9WSdA51nobo255iXW11zMCTN9c+7K zxsw== X-Gm-Message-State: AOAM5338ui71+li2vLt+cwqcGFn6cdDcIR57hwPcBDCcakwQH9oqolpX 5s6QMrCFL7c4/wJi4dqdErRShZYGJNDlHicC62n7zA== X-Google-Smtp-Source: ABdhPJxsrkSYKmMolrGDzGBzVUCmpV4Czal5MWGq3rA63F0c5cGNbbd8XSdXd5KOBCD+j1AK6KQkyAzoPLSK90Osl+U= X-Received: by 2002:a2e:81c5:: with SMTP id s5mr11803430ljg.372.1591087248899; Tue, 02 Jun 2020 01:40:48 -0700 (PDT) MIME-Version: 1.0 References: <1588758017-30426-1-git-send-email-sumit.garg@linaro.org> <1588758017-30426-2-git-send-email-sumit.garg@linaro.org> <20200601021132.GA796225@linux.intel.com> <20200602071407.GB16602@linux.intel.com> In-Reply-To: <20200602071407.GB16602@linux.intel.com> From: Sumit Garg Date: Tue, 2 Jun 2020 14:10:37 +0530 Message-ID: Subject: Re: [PATCH v4 1/4] KEYS: trusted: Add generic trusted keys framework To: Jarkko Sakkinen Cc: Mimi Zohar , James Bottomley , dhowells@redhat.com, Jens Wiklander , Jonathan Corbet , James Morris , "Serge E. Hallyn" , Casey Schaufler , Janne Karhunen , Daniel Thompson , Markus Wamser , "open list:ASYMMETRIC KEYS" , linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, Linux Doc Mailing List , Linux Kernel Mailing List , linux-arm-kernel , op-tee@lists.trustedfirmware.org, "tee-dev @ lists . linaro . org" Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Tue, 2 Jun 2020 at 12:44, Jarkko Sakkinen wrote: > > On Mon, Jun 01, 2020 at 02:41:55PM +0530, Sumit Garg wrote: > > > This, I think is wrong. You should have a compile time flag for TPM e.g. > > > CONFIG_TRUSTED_TPM, not this dynamic mess. > > > > > > > The whole idea to have it dynamic was to have a common trusted keys > > module which could support both TPM and TEE implementation depending > > on hardware. I guess it may be useful in scenarios where a particular > > hardware supports a TPM chip while other doesn't but both need to run > > a common kernel image. > > For now it should only scale to what is needed. No problems refining > it later when there is something to enable. > Fair enough, will switch to compile time mode then. -Sumit > /Jarkko