From: Richard Weinberger <richard.weinberger@gmail.com>
To: James Morris <jmorris@namei.org>
Cc: Matthew Garrett <mjg59@google.com>,
David Howells <dhowells@redhat.com>,
Joern Engel <joern@lazybastard.org>,
LSM List <linux-security-module@vger.kernel.org>,
Ben Hutchings <ben@decadent.org.uk>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH 2/2] mtd: phram,slram: Disable when the kernel is locked down
Date: Wed, 11 Sep 2019 00:18:49 +0200 [thread overview]
Message-ID: <CAFLxGvxRVwt0=wtKJnZB6s+VDCoGT3vsW27P2MECO999sJKAHw@mail.gmail.com> (raw)
In-Reply-To: <alpine.LRH.2.21.1909100816170.3709@namei.org>
On Tue, Sep 10, 2019 at 5:17 PM James Morris <jmorris@namei.org> wrote:
>
> On Tue, 10 Sep 2019, Matthew Garrett wrote:
>
> > On Fri, Aug 30, 2019 at 11:47 AM Ben Hutchings <ben@decadent.org.uk> wrote:
> > >
> > > These drivers allow mapping arbitrary memory ranges as MTD devices.
> > > This should be disabled to preserve the kernel's integrity when it is
> > > locked down.
> > >
> > > * Add the HWPARAM flag to the module parameters
> > > * When slram is built-in, it uses __setup() to read kernel parameters,
> > > so add an explicit check security_locked_down() check
> > >
> > > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > > Cc: Matthew Garrett <mjg59@google.com>
> > > Cc: David Howells <dhowells@redhat.com>
> > > Cc: Joern Engel <joern@lazybastard.org>
> > > Cc: linux-mtd@lists.infradead.org
> >
> > Reviewed-by: Matthew Garrett <mjg59@google.com>
> >
> > James, should I pick patches like this up and send them to you, or
> > will you queue them directly after they're acked?
>
> As long as I'm on the to or cc when they're acked, I can grab them.
Acked-by: Richard Weinberger <richard@nod.at>
BTW: I don't have 1/2 in my inbox, is it also MTD related?
--
Thanks,
//richard
next prev parent reply other threads:[~2019-09-10 22:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 15:45 [PATCH 1/2] staging: comedi: Restrict COMEDI_DEVCONFIG when the kernel is locked down Ben Hutchings
2019-08-30 15:47 ` [PATCH 2/2] mtd: phram,slram: Disable " Ben Hutchings
2019-09-10 14:27 ` Matthew Garrett
2019-09-10 15:17 ` James Morris
2019-09-10 22:18 ` Richard Weinberger [this message]
2019-09-10 23:43 ` Ben Hutchings
2019-08-30 17:35 ` [PATCH 1/2] staging: comedi: Restrict COMEDI_DEVCONFIG " Ian Abbott
2019-08-31 9:50 ` Ben Hutchings
2019-09-02 9:26 ` Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFLxGvxRVwt0=wtKJnZB6s+VDCoGT3vsW27P2MECO999sJKAHw@mail.gmail.com' \
--to=richard.weinberger@gmail.com \
--cc=ben@decadent.org.uk \
--cc=dhowells@redhat.com \
--cc=jmorris@namei.org \
--cc=joern@lazybastard.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mjg59@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).