From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1DB8C7112C for ; Tue, 23 Oct 2018 18:50:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8B18420665 for ; Tue, 23 Oct 2018 18:50:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="PWSrGUOb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B18420665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-security-module-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728771AbeJXDPF (ORCPT ); Tue, 23 Oct 2018 23:15:05 -0400 Received: from mail-yw1-f67.google.com ([209.85.161.67]:45679 "EHLO mail-yw1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728619AbeJXDPE (ORCPT ); Tue, 23 Oct 2018 23:15:04 -0400 Received: by mail-yw1-f67.google.com with SMTP id i185-v6so982689ywa.12 for ; Tue, 23 Oct 2018 11:50:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=MLwe1V3+WJhm5IZOKBCWNwMrf6D/NJnM+bO9U6nJ9WI=; b=PWSrGUObF5SXc5Gy1kASJRkZcqkf5AaV68TJcvLo9+ZpDzbkyyQnt7RGDTsvNkUIpl YXGOhnMSilor+kLqcNu0xBBwrk77xeqXIoILYfus1H/+A1kA2ZAXED3/5QYkaKeHU3hA MNRhWWUFNF65xWLVx0vrJke+PykxNIFOanEZs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=MLwe1V3+WJhm5IZOKBCWNwMrf6D/NJnM+bO9U6nJ9WI=; b=TZgoB4wKdAtx+8SWJqhbz+k/ziRS9gVZnGaafkzbRC6U/A4cmpSxporlWocE1C9KGH tOxOBO7/hNGPhrFPa5BDPob9btpVQll2aPg4+IH4INRpWzxKettypowOYRf8YKRrmzqm 83rnw+HiGbQHkthXpeV8fFi1HBHLIOHYo7pUKR1BMPbhYfYXdHU7wUC4ZagsrjNakXac 8Asy2oN6bidzyPA0mZMJKji5YDEeWV3hqdY5DmNgGeJl/UvUsf4N/8clVAaR7bg+23Qv y+cpymQSgPyzJfKB5SNom3CsD4IF/QEc3eBOFfFM0GGba0tl3aw2y7ZLlEdQzfeiEBUA yNBQ== X-Gm-Message-State: ABuFfoiLu6yhqZjz+EFmC2y5kDDuexaYem4RX5MgRG/UDcHg+VKKIX3c /5iz/07zbwb8avspbfnZ61WZkLwRl1I= X-Google-Smtp-Source: ACcGV63g0ds//m3C1vyUYXso2eBwS4GIA5mBc5vQiUOyvTHdyGiQOf6u03ACIvXRzRsDSQ7h/78uwA== X-Received: by 2002:a0d:d144:: with SMTP id t65-v6mr35890518ywd.449.1540320625847; Tue, 23 Oct 2018 11:50:25 -0700 (PDT) Received: from mail-yw1-f44.google.com (mail-yw1-f44.google.com. [209.85.161.44]) by smtp.gmail.com with ESMTPSA id 80-v6sm1120102ywh.55.2018.10.23.11.50.22 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Oct 2018 11:50:23 -0700 (PDT) Received: by mail-yw1-f44.google.com with SMTP id z206-v6so994159ywb.3 for ; Tue, 23 Oct 2018 11:50:22 -0700 (PDT) X-Received: by 2002:a81:9b83:: with SMTP id s125-v6mr36333374ywg.47.1540320621970; Tue, 23 Oct 2018 11:50:21 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:3990:0:0:0:0:0 with HTTP; Tue, 23 Oct 2018 11:50:21 -0700 (PDT) In-Reply-To: <96e92224-aedf-5026-d6dd-b29121b4dc0d@schaufler-ca.com> References: <20181011001846.30964-1-keescook@chromium.org> <32stV62RmME8Dj5jKB8Z03zPe_Et72kMo71D8SpgSOHUo6SaROc8DomMWdk5jDGpyqVd8T63NIIK2NdDw95clpF8Uj47Wca2FBFItXDRh7E=@protonmail.ch> <38dde301-d77e-35fd-88d4-5cdc5b570ee8@canonical.com> <_CkJnKYmEZ4ZF0JtsSYuahAd9sgnX9OtcstjXaeqb8wn5uxfimc6S4jomly7If9VqnOXqXwaiCbJ9ttS6NiqE7n6cQUlwLvfO53paLmacvU=@protonmail.ch> <8251564f-ba7a-1777-a606-dec472b32f35@canonical.com> <96e92224-aedf-5026-d6dd-b29121b4dc0d@schaufler-ca.com> From: Kees Cook Date: Tue, 23 Oct 2018 11:50:21 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH security-next v5 00/30] LSM: Explict ordering To: Casey Schaufler Cc: John Johansen , Jordan Glover , James Morris , Stephen Smalley , Paul Moore , Tetsuo Handa , Mimi Zohar , Randy Dunlap , LSM , "open list:DOCUMENTATION" , linux-arch , LKML Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Tue, Oct 23, 2018 at 9:48 AM, Casey Schaufler wrote: > On 10/12/2018 12:01 PM, Kees Cook wrote: >> On Friday, October 12, 2018 3:19 AM, John Johansen >> wrote: >>> It isn't perfect but it manages consistency across distros as best as >>> can be achieved atm. >> Yeah, this is why I'm okay with the current series: it provides as >> consistent a view as possible, but leaves room for future improvements >> (like adding "+" or "!" or "all" or whatever). >> >> I'm curious to see what SELinux folks think of v5, though. I *think* I >> addressed all the concerns there, even Paul's "I want my distro >> default to not have extreme stacking" case too. >> >> -Kees > > Looks like I should go on vacation more often. :) > > I am generally opposed to fancy specification languages. > I support the explicit lsm= list specification because you > don't have to know any context to create a boot line that > will work, and be as close to what you've specified as possible > for the kernel configuration. One need look no further than > the mechanisms for setting POSIX ACLs for an example of > how to ensure a feature isn't used. > > Had we the foresight to make security= take a list of > modules when Yama was added we might have avoided some of > this brouhaha, but there was no reason to expect that stacking > was ever going to happen back then. This sounds like an "Ack" for you? :) I'll harass everyone in person in a couple days. Did you poke around at my combined series? https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/log/?h=lsm/ordering-v6-blob-sharing -Kees -- Kees Cook Pixel Security