From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64F4CC3A5A4 for ; Sun, 1 Sep 2019 18:23:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 381A822CF7 for ; Sun, 1 Sep 2019 18:23:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore-com.20150623.gappssmtp.com header.i=@paul-moore-com.20150623.gappssmtp.com header.b="eq6vzzUP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729077AbfIASX0 (ORCPT ); Sun, 1 Sep 2019 14:23:26 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:39670 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728982AbfIASX0 (ORCPT ); Sun, 1 Sep 2019 14:23:26 -0400 Received: by mail-lj1-f195.google.com with SMTP id j16so4670752ljg.6 for ; Sun, 01 Sep 2019 11:23:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eRqNO50sqHwmWj5P/z58Oe0GaZOHE7FRmJRU0BNdRwA=; b=eq6vzzUPapsds+MIIuvqwfoZXAY0z41n2/7fdowjYx2O5oU38D0z/W/9glcxHRQa2e WYf410OXkTry4hw084nNU6/X7cFg1locgtY1vqUfOpwr826VafO+TCzi/6t+ttlshkC+ Sijt9vi6vCi5dE6sI0/8gicWxGp5RchwTfcn7sp2LKVu62LRHYFb14OqYn/1pJpGmPef Aj7b+7Bjar191/oCxIVpcgP7PF40d+4DN5npPXMykV6beMkf4rgkProguELGZMDzpeLM PrbjKM3rbaqyDlThN1cmN4fO3M5I2yb3ZTA5WYMWuKdsF5nZiMa/eBim7YPJaP48caWx hkkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eRqNO50sqHwmWj5P/z58Oe0GaZOHE7FRmJRU0BNdRwA=; b=iPMSROs9msZ6GThRGzP8r9XoLWT5S2B+jliaO0/BQMdsgqJxzVvwHeMu2Ljw/yMONf r8Tb36e9ThED3dRcyVUZvBe3YxwGyQ4D4xV4myHfGZsj3B5BRWacQ/cA1xNThY1PS0s/ 0S7iAv1pLB021wmuMrhmOtPP5rRkeIryQU97INEWQQDrmN4oT67WOmkxbNJ/o/LrTrP/ 3fYzWJuo3Xpr/Uu8xyzJtrIoqBRQF/QAEFEBvr++8BJ1YWeJy3lcjOmGptzTjps+/GF1 gY/UF0iJVBY1CxUwubqwvSkTtFkg+Bp8UGoEKwutoIpRNBKpOCmUyNOsxDshfgnr0q26 Z1OQ== X-Gm-Message-State: APjAAAVCgIJ4dFM7HLOHGTuAkw55EqtlJHw+LpxU/RnmvbZLtHE6BduF DvH7GkTFh2KczvGKXb26JG735y5wsRUXDaI+V1RTfik= X-Google-Smtp-Source: APXvYqxR838XZ/vlMKbRK5g41cM9jK0LAXal1wmVLKOlFPo3+6Zm04hAQdB16tAZbBIQ1PFDnVj27P0uotkvqRNwnFI= X-Received: by 2002:a05:651c:93:: with SMTP id 19mr14338697ljq.0.1567362204210; Sun, 01 Sep 2019 11:23:24 -0700 (PDT) MIME-Version: 1.0 References: <20190901155205.16877-1-colin.king@canonical.com> In-Reply-To: <20190901155205.16877-1-colin.king@canonical.com> From: Paul Moore Date: Sun, 1 Sep 2019 14:23:12 -0400 Message-ID: Subject: Re: [PATCH] netlabel: remove redundant assignment to pointer iter To: Colin King Cc: "David S . Miller" , netdev@vger.kernel.org, linux-security-module@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Sun, Sep 1, 2019 at 11:52 AM Colin King wrote: > From: Colin Ian King > > Pointer iter is being initialized with a value that is never read and > is being re-assigned a little later on. The assignment is redundant > and hence can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > net/netlabel/netlabel_kapi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Paul Moore > diff --git a/net/netlabel/netlabel_kapi.c b/net/netlabel/netlabel_kapi.c > index 2b0ef55cf89e..409a3ae47ce2 100644 > --- a/net/netlabel/netlabel_kapi.c > +++ b/net/netlabel/netlabel_kapi.c > @@ -607,7 +607,7 @@ static struct netlbl_lsm_catmap *_netlbl_catmap_getnode( > */ > int netlbl_catmap_walk(struct netlbl_lsm_catmap *catmap, u32 offset) > { > - struct netlbl_lsm_catmap *iter = catmap; > + struct netlbl_lsm_catmap *iter; > u32 idx; > u32 bit; > NETLBL_CATMAP_MAPTYPE bitmap; > -- > 2.20.1 -- paul moore www.paul-moore.com