From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 258FEC61DB3 for ; Thu, 12 Jan 2023 18:02:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240069AbjALSCE (ORCPT ); Thu, 12 Jan 2023 13:02:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229524AbjALSBQ (ORCPT ); Thu, 12 Jan 2023 13:01:16 -0500 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9A6613CF5 for ; Thu, 12 Jan 2023 09:22:08 -0800 (PST) Received: by mail-pj1-x102c.google.com with SMTP id o1-20020a17090a678100b00219cf69e5f0so24293531pjj.2 for ; Thu, 12 Jan 2023 09:22:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0xDr4QknDNxPi2cT8FrUuwNvsQNO379ZboIpi4mwvIk=; b=Fiy522RNvvYxq4nWHpNZeEHiH1/P9P8SLmCZIIqj2T5uix0e9SLinDtq8qjCWr3RvO M++tjLHwR63OcuftzaEi1ChHQB/nAHWAlphG1r3019blrCX5ANTv/XcoJVZFBBzi6aUe MvLJxuqoSKKFHXXwDx19ZDLhPn5pfMZSOuEkIskLBENuvcoYcn3D/7ZnF+V0JdJj2ozl w3ZMpd9CGXnSWHPtu6A4IicaLCensH+4iBwQSp85GIynWT/+gTgkDRA2xQ+ry9YEolgp /TFO++DWjtppIUWlzcQtHMiWEruGd66Jn+076IgtMtnBQOtWeZNPvs9hxtIGRLFYmktV Etnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0xDr4QknDNxPi2cT8FrUuwNvsQNO379ZboIpi4mwvIk=; b=XzgPrdLgro28C+br4kXOlhEVvigqsGnhghmyGHaedIfZhyzJUxsgJRRLPJ/9juV3tF s3+O1YdNihkEgXtud+f4Pldqxzc8cpxBd4PbbAe0wtqDz/ddfwvpMK5NXeQ/wObIVTe1 zhaexR3uUzmWjjlkey1rDbRQ7Ba1Y8UBqthFwiTmmnERmRhmwx/yOBZSpb3+YvcwMPbw WJ4/pmc53QbLoCyI69tsExK3V18Hw38sz7sLjKeDvwWpegTqAzAk/63y1Hp9DVRAdPEC AnVbLdsAb3yR2VYwhcefrYVGhaHPE6MPac8WpH/wOP0ixpsMNkG+rrX/H5jAU5te2zmV WolA== X-Gm-Message-State: AFqh2kqvLd3ROHK4NIUOlXkvDD6kTPTp0ePl9+5jpZhmPLJSEkKiA9w2 SjEgq6eMxbzj2wI1phcpHB2rOuYAbOyDv9GeeTlx X-Google-Smtp-Source: AMrXdXu2M2VDaYhrvTSfy4I4j0IQ3Wj0M50ON3uTCXgABm7WK5YXNWc5b+Li6BFUEvojgI035C9WkWYZx2mqYyqriPo= X-Received: by 2002:a17:902:cec8:b0:192:6675:8636 with SMTP id d8-20020a170902cec800b0019266758636mr4530544plg.15.1673544128229; Thu, 12 Jan 2023 09:22:08 -0800 (PST) MIME-Version: 1.0 References: <20221201104125.919483-1-roberto.sassu@huaweicloud.com> <20221201104125.919483-3-roberto.sassu@huaweicloud.com> <6905166125130c22c244ebf234723d1587a01ae8.camel@huaweicloud.com> In-Reply-To: <6905166125130c22c244ebf234723d1587a01ae8.camel@huaweicloud.com> From: Paul Moore Date: Thu, 12 Jan 2023 12:21:57 -0500 Message-ID: Subject: Re: [PATCH v7 2/6] ocfs2: Switch to security_inode_init_security() To: Roberto Sassu Cc: mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, zohar@linux.ibm.com, dmitry.kasatkin@gmail.com, jmorris@namei.org, serge@hallyn.com, stephen.smalley.work@gmail.com, eparis@parisplace.org, casey@schaufler-ca.com, ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, linux-kernel@vger.kernel.org, keescook@chromium.org, nicolas.bouchinet@clip-os.org, Roberto Sassu Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: On Tue, Jan 10, 2023 at 3:56 AM Roberto Sassu wrote: > On Thu, 2022-12-01 at 11:41 +0100, Roberto Sassu wrote: > > From: Roberto Sassu > > > > In preparation for removing security_old_inode_init_security(), switch to > > security_inode_init_security(). > > > > Extend the existing ocfs2_initxattrs() to take the > > ocfs2_security_xattr_info structure from fs_info, and populate the > > name/value/len triple with the first xattr provided by LSMs. > > Hi Mark, Joel, Joseph > > some time ago I sent this patch set to switch to the newer > function security_inode_init_security(). Almost all the other parts of > this patch set have been reviewed, and the patch set itself should be > ready to be merged. > > I kindly ask if you could have a look at this patch and give your > Reviewed-by, so that Paul could take the patch set. I've been pushing to clean up some of the LSM interfaces to try and simplify things and remove as many special cases as possible, Roberto's work in this patchset is part of that. I would really appreciate it if the vfs/ocfs2 folks could give patch 2/6 a quick look to make sure you are okay with the changes. I realize that the various end-of-year holidays tend to slow things down a bit, but this patchset has been on the lists for over a month now; if I don't hear anything in the next week or two I'll assume you folks are okay with these patches ... -- paul-moore.com