From: Paul Moore <paul@paul-moore.com>
To: Roberto Sassu <roberto.sassu@huaweicloud.com>
Cc: casey@schaufler-ca.com, omosnace@redhat.com,
john.johansen@canonical.com, kpsingh@kernel.org,
bpf@vger.kernel.org, linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org,
Roberto Sassu <roberto.sassu@huawei.com>
Subject: Re: [PATCH v2 2/2] lsm: Add/fix return values in lsm_hooks.h and fix formatting
Date: Tue, 6 Dec 2022 19:21:50 -0500 [thread overview]
Message-ID: <CAHC9VhRx=pCcAHMAX+51rpFT+efW7HH=X37YOwUG1tTLxyg=SA@mail.gmail.com> (raw)
In-Reply-To: <20221128144240.210110-3-roberto.sassu@huaweicloud.com>
On Mon, Nov 28, 2022 at 9:43 AM Roberto Sassu
<roberto.sassu@huaweicloud.com> wrote:
> From: Roberto Sassu <roberto.sassu@huawei.com>
>
> Ensure that for non-void LSM hooks there is a description of the return
> values.
>
> Also, replace spaces with tab for indentation, remove empty lines between
> the hook description and the list of parameters, adjust semicolons and add
> the period at the end of the parameter description.
>
> Finally, move the description of gfp parameter of the
> xfrm_policy_alloc_security hook together with the others.
>
> Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
> ---
> include/linux/lsm_hooks.h | 221 ++++++++++++++++++++++++--------------
> 1 file changed, 138 insertions(+), 83 deletions(-)
Thanks Roberto, I've merged this into lsm/next with one small tweak (below).
> diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h
> index c35e260efd8c..6502a1bea93a 100644
> --- a/include/linux/lsm_hooks.h
> +++ b/include/linux/lsm_hooks.h
> @@ -677,7 +695,7 @@
> * indicates which of the set*uid system calls invoked this hook. If
> * @new is the set of credentials that will be installed. Modifications
> * should be made to this rather than to @current->cred.
> - * @old is the set of credentials that are being replaces
> + * @old is the set of credentials that are being replaces.
Might as well change "replaces" to "replaced". I'll go ahead and fix
that up during the merge.
--
paul-moore.com
next prev parent reply other threads:[~2022-12-07 0:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 14:42 [PATCH v2 0/2] lsm: Improve LSM hooks documentation Roberto Sassu
2022-11-28 14:42 ` [PATCH v2 1/2] lsm: Clarify documentation of vm_enough_memory hook Roberto Sassu
2022-12-06 22:51 ` Paul Moore
2022-11-28 14:42 ` [PATCH v2 2/2] lsm: Add/fix return values in lsm_hooks.h and fix formatting Roberto Sassu
2022-12-07 0:21 ` Paul Moore [this message]
2022-12-07 7:58 ` Roberto Sassu
2022-12-07 9:17 ` Roberto Sassu
2022-12-07 19:34 ` Paul Moore
2022-12-08 9:29 ` Roberto Sassu
2022-12-08 21:59 ` Paul Moore
2022-12-08 22:18 ` Casey Schaufler
2022-11-29 16:48 ` [PATCH v2 0/2] lsm: Improve LSM hooks documentation Casey Schaufler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHC9VhRx=pCcAHMAX+51rpFT+efW7HH=X37YOwUG1tTLxyg=SA@mail.gmail.com' \
--to=paul@paul-moore.com \
--cc=bpf@vger.kernel.org \
--cc=casey@schaufler-ca.com \
--cc=john.johansen@canonical.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=omosnace@redhat.com \
--cc=roberto.sassu@huawei.com \
--cc=roberto.sassu@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).