linux-security-module.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Moore <paul@paul-moore.com>
To: James Morris <jmorris@namei.org>
Cc: selinux@vger.kernel.org, Stephen Smalley <sds@tycho.nsa.gov>,
	linux-security-module@vger.kernel.org, mszeredi@redhat.com,
	bfields@fieldses.org
Subject: Re: SELinux testsuite failure in overlayfs with v4.20-rc kernels
Date: Wed, 12 Dec 2018 17:24:06 -0500	[thread overview]
Message-ID: <CAHC9VhTGF3SxRh0iTMhqFYExh3HrKVn7Wnko-_hb+y+6BmCRaQ@mail.gmail.com> (raw)
In-Reply-To: <alpine.LRH.2.21.1812130915190.5053@namei.org>

On Wed, Dec 12, 2018 at 5:19 PM James Morris <jmorris@namei.org> wrote:
> The SELinux testsuite is failing in the overlayfs tests in current -rc
> kernels. I bisected the issue to
>
> commit 007ea44892e6fa963a0876a979e34890325c64eb
> Author: Miklos Szeredi <mszeredi@redhat.com>
> Date:   Fri Oct 26 23:34:39 2018 +0200
>
>     ovl: relax permission checking on underlying layers
>
>     Make permission checking more consistent:
>
>      - special files don't need any access check on underling fs
>
>      - exec permission check doesn't need to be performed on underlying fs
>
>     Reported-by: "J. Bruce Fields" <bfields@fieldses.org>
>     Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
>
> Reverting this commit fixes the testsuite failure.
>
> Is there any more information on the rationale for the change?

This is a known problem, see the archive link below, with Miklos
promising to send a revert to Linus for v4.20.  I just pinged him
earlier this week to remind him, but I haven't heard back yet and I
don't see anything in Linus' tree.

I would much prefer if Miklos sent the revert, but if he doesn't send
the revert by the end of the week, I'm going to send one next week.

https://lore.kernel.org/selinux/CAJfpeguJoEOEjQs4ZpJQaJXF-xCnevUApzNobwmqNX27KQ4vHQ@mail.gmail.com

-- 
paul moore
www.paul-moore.com

  reply	other threads:[~2018-12-12 22:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-12 22:18 SELinux testsuite failure in overlayfs with v4.20-rc kernels James Morris
2018-12-12 22:24 ` Paul Moore [this message]
2018-12-12 23:35   ` James Morris
2018-12-12 23:37   ` James Morris
2018-12-13 14:33     ` Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHC9VhTGF3SxRh0iTMhqFYExh3HrKVn7Wnko-_hb+y+6BmCRaQ@mail.gmail.com \
    --to=paul@paul-moore.com \
    --cc=bfields@fieldses.org \
    --cc=jmorris@namei.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=mszeredi@redhat.com \
    --cc=sds@tycho.nsa.gov \
    --cc=selinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).