Linux-Security-Module Archive on lore.kernel.org
 help / Atom feed
* [PATCH]  security/selinux/hooks: remove unneeded semicolon
@ 2019-01-04  9:19 Peng Hao
  2019-01-10  0:54 ` Paul Moore
  0 siblings, 1 reply; 2+ messages in thread
From: Peng Hao @ 2019-01-04  9:19 UTC (permalink / raw)
  To: paul, sds, eparis; +Cc: linux-security-module, linux-kernel, Peng Hao

Remove unneeded semicolon.

Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
---
 security/selinux/hooks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index a67459e..73c679e 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -1263,7 +1263,7 @@ static void selinux_write_opts(struct seq_file *m,
 		default:
 			BUG();
 			return;
-		};
+		}
 		/* we need a comma before each option */
 		seq_putc(m, ',');
 		seq_puts(m, prefix);
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] security/selinux/hooks: remove unneeded semicolon
  2019-01-04  9:19 [PATCH] security/selinux/hooks: remove unneeded semicolon Peng Hao
@ 2019-01-10  0:54 ` Paul Moore
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Moore @ 2019-01-10  0:54 UTC (permalink / raw)
  To: Peng Hao
  Cc: Stephen Smalley, Eric Paris, linux-security-module, linux-kernel,
	selinux

On Thu, Jan 3, 2019 at 7:55 PM Peng Hao <peng.hao2@zte.com.cn> wrote:
>
> Remove unneeded semicolon.
>
> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
> ---
>  security/selinux/hooks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index a67459e..73c679e 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -1263,7 +1263,7 @@ static void selinux_write_opts(struct seq_file *m,
>                 default:
>                         BUG();
>                         return;
> -               };
> +               }
>                 /* we need a comma before each option */
>                 seq_putc(m, ',');
>                 seq_puts(m, prefix);

Thank you for your patch, but the selinux_write_opts() function was
just removed in v5.0-rc1 in commit e3489f8974e1 ("selinux: kill
selinux_sb_get_mnt_opts()").

-- 
paul moore
www.paul-moore.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-04  9:19 [PATCH] security/selinux/hooks: remove unneeded semicolon Peng Hao
2019-01-10  0:54 ` Paul Moore

Linux-Security-Module Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-security-module/0 linux-security-module/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-security-module linux-security-module/ https://lore.kernel.org/linux-security-module \
		linux-security-module@vger.kernel.org linux-security-module@archiver.kernel.org
	public-inbox-index linux-security-module


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-security-module


AGPL code for this site: git clone https://public-inbox.org/ public-inbox