From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2817C4332F for ; Fri, 3 Sep 2021 06:31:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C850F6102A for ; Fri, 3 Sep 2021 06:31:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344368AbhICGcS (ORCPT ); Fri, 3 Sep 2021 02:32:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:35503 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345522AbhICGcQ (ORCPT ); Fri, 3 Sep 2021 02:32:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630650677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YC/rlauU/F6bmxF77VH11Mgk4hV/IwCNeLbfbf9xP5Q=; b=EHmwW6fcOI/wuEw2OYTKfHKaLTaDMBQaC33fCb4ExhoKeJa8v/4ieG7M2gR93KbCpDNf1e 9Dz/rRbBpkiYviiI14b8XRFUH2sFUqUSxH9JUtWXyxpn69yuDEO5nKXDx1XXXB1yMCCEPr mfHbt0XJ7EvMWXqqI9sOHYhf/M0pTPI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-123-mqrHoYhhO86_rQ9ddyeG2Q-1; Fri, 03 Sep 2021 02:31:15 -0400 X-MC-Unique: mqrHoYhhO86_rQ9ddyeG2Q-1 Received: by mail-wm1-f71.google.com with SMTP id p29-20020a1c545d000000b002f88d28e1f1so589617wmi.7 for ; Thu, 02 Sep 2021 23:31:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YC/rlauU/F6bmxF77VH11Mgk4hV/IwCNeLbfbf9xP5Q=; b=HchtJzYLza7kwKQORHBfVggOJIfIqLNc2WmzgVcLa47kL6zdl+nIMRtOA+TAhqwKtJ jw5hL0STwAmWgbVzmtjq39POZnlbIfkHxiiOUbf+IOOyQ1JgxCBSrjIoTMFCmYFzOOga zzTZonLmwWzW+krM/K+1WJZt6SJ15lDJLzR32IFOC9cYgqQgBnehteoKoUBymv2H+P1i 3P/XVaT96m5v2pRjtFKNqvT8qxfNsGmfD6QgvnPdaYzJm/z7MLCej8ZlcdKsWkRb6X1m pzhWrmXY5i+YOTFKD/2pFgQDWWTae7Z+nCZI242vZBhBOiKUCfERkPH89asURWr/E0G/ 9Xxw== X-Gm-Message-State: AOAM533/8Bek9c+FQcsvl532Cu905bXOj/jV2sb2LE/K3BP/h9SgvYx7 8WrKwpMlmwaY1EMHNXAR/BOQvEM6f6c3xKW4bXUh/72xdNrNhegS8+AqpncrVpaJ7gWK6ZZ3sKw 1WNDJvGkkkf7GYGFX8wQSdzreyM6UDeD/uePMH17eNeYwFXNAxfBQ X-Received: by 2002:adf:d193:: with SMTP id v19mr2009424wrc.377.1630650674676; Thu, 02 Sep 2021 23:31:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwyPFJw9ZP/m1ileU46mEBJVAfh6Zf+O3xQQjDX0TV+sCc5/OMAl/XmaZX2RmznLFq2omumgxC7UK2vm0m9SxM= X-Received: by 2002:adf:d193:: with SMTP id v19mr2009383wrc.377.1630650674468; Thu, 02 Sep 2021 23:31:14 -0700 (PDT) MIME-Version: 1.0 References: <20210902152228.665959-1-vgoyal@redhat.com> In-Reply-To: From: Andreas Gruenbacher Date: Fri, 3 Sep 2021 08:31:03 +0200 Message-ID: Subject: Re: [PATCH 3/1] xfstests: generic/062: Do not run on newer kernels To: Vivek Goyal Cc: fstests , linux-fsdevel , LKML , virtio-fs@redhat.com, dwalsh@redhat.com, dgilbert@redhat.com, christian.brauner@ubuntu.com, casey.schaufler@intel.com, LSM , selinux@vger.kernel.org, "Theodore Ts'o" , Miklos Szeredi , gscrivan@redhat.com, "Fields, Bruce" , stephen.smalley.work@gmail.com, Dave Chinner , Alexander Viro Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=agruenba@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: On Thu, Sep 2, 2021 at 5:47 PM Vivek Goyal wrote: > xfstests: generic/062: Do not run on newer kernels > > This test has been written with assumption that setting user.* xattrs will > fail on symlink and special files. When newer kernels support setting > user.* xattrs on symlink and special files, this test starts failing. It's actually a good thing that this test case triggers for the kernel change you're proposing; that change should never be merged. The user.* namespace is meant for data with the same access permissions as the file data, and it has been for many years. We may have applications that assume the existing behavior. In addition, this change would create backwards compatibility problems for things like backups. I'm not convinced that what you're actually proposing (mapping security.selinux to a different attribute name) actually makes sense, but that's a question for the selinux folks to decide. Mapping it to a user.* attribute is definitely wrong though. The modified behavior would affect anybody, not only users of selinux and/or virtiofs. If mapping attribute names is actually the right approach, then you need to look at trusted.* xattrs, which exist specifically for this kind of purpose. You've noted that trusted.* xattrs aren't supported over nfs. That's unfortunate, but not an acceptable excuse for messing up user.* xattrs. Thanks, Andreas