From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94914C433EF for ; Fri, 3 Sep 2021 06:56:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7371360FC4 for ; Fri, 3 Sep 2021 06:56:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347463AbhICG52 (ORCPT ); Fri, 3 Sep 2021 02:57:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:53139 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347494AbhICG5V (ORCPT ); Fri, 3 Sep 2021 02:57:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630652181; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CMU0FH7DhLi0oHnmcQCBzsX4HoHYqzZdV2dtgL7VZJc=; b=ImvSd75lhKyg+s6ZZKV5gbBfyYHXh7u+7vvpkv8dnmBYGFkWVMHqlJZcV7CJ0JPXD/x//m 2xLAA0fHHKUlCw4Iy7fhoXbmfOsVKJJSPrilK5owMMOpJlRmltVF8VRvaANk83vu4cLCmI 0etvoKkfNy6TOo78KDLE3RtG6XSRenI= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-580-6z7iFS5WOkSuM0GyqKlAuQ-1; Fri, 03 Sep 2021 02:56:21 -0400 X-MC-Unique: 6z7iFS5WOkSuM0GyqKlAuQ-1 Received: by mail-wm1-f70.google.com with SMTP id x125-20020a1c3183000000b002e73f079eefso2276468wmx.0 for ; Thu, 02 Sep 2021 23:56:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CMU0FH7DhLi0oHnmcQCBzsX4HoHYqzZdV2dtgL7VZJc=; b=H4i812Afd86pjaf2mn5Sm90Fpzi9wqKp9iSxd0EAecWCHESl37IeZLUFBP3Uz/2RXI vFFYFBQnTYg9AT7eHJ2Lsm0tdxGnPTVLlLrst6R7vyV+Q3bRnKzCrveiB7u8NqV/FR+4 tPKFp4yato/kyWvwEwAniuthrh4P/ksDO0JyFuPGl7T9KXNxCvR6QWiSB0nkykSvpR+O RDOc8pc8rrE9NcbbGPoXS3cjijRFZprxRkQ+c//gcnANV4SRlloMN0jgkk7vc8dv67RE 0UZ20E/VFancMnFS9nIkcBi+TlV2sTkxVD2qc7IEoy8rtHXJBys+cqJtLT0Q9As6lW1+ LUQA== X-Gm-Message-State: AOAM532Dm6RqATgM6MkH1AqZokl7dDyb6MpDVM+bHKtWttGIlEQpub4I V3jdVwnZVyO8DHq68c2SgB/5GDUFUuT3hqDQ/pJF+EDv8P89KBj8FhlhtqCF7K80PpAb/ODSLCH HTg8uuWkTHVHf0myrkyoQlf7BhYnAkhFsx1x2xv0Zi+1qUgTswe63 X-Received: by 2002:a05:600c:1c08:: with SMTP id j8mr1757634wms.27.1630652179828; Thu, 02 Sep 2021 23:56:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwEMgRhDhAirpF+1BwSzCXJ2JmOX/csrcn3G6xdkU4jNs0c3KyXpXRLPYTJcObTec0xa9Qcz/PI2DFfXbdCfYE= X-Received: by 2002:a05:600c:1c08:: with SMTP id j8mr1757607wms.27.1630652179603; Thu, 02 Sep 2021 23:56:19 -0700 (PDT) MIME-Version: 1.0 References: <20210902152228.665959-1-vgoyal@redhat.com> In-Reply-To: From: Andreas Gruenbacher Date: Fri, 3 Sep 2021 08:56:08 +0200 Message-ID: Subject: Re: [PATCH 3/1] xfstests: generic/062: Do not run on newer kernels To: Vivek Goyal Cc: fstests , linux-fsdevel , LKML , virtio-fs@redhat.com, dwalsh@redhat.com, dgilbert@redhat.com, christian.brauner@ubuntu.com, casey.schaufler@intel.com, LSM , selinux@vger.kernel.org, "Theodore Ts'o" , Miklos Szeredi , gscrivan@redhat.com, "Fields, Bruce" , stephen.smalley.work@gmail.com, Dave Chinner , Alexander Viro Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=agruenba@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: On Fri, Sep 3, 2021 at 8:31 AM Andreas Gruenbacher wrote: > On Thu, Sep 2, 2021 at 5:47 PM Vivek Goyal wrote: > > xfstests: generic/062: Do not run on newer kernels > > > > This test has been written with assumption that setting user.* xattrs will > > fail on symlink and special files. When newer kernels support setting > > user.* xattrs on symlink and special files, this test starts failing. > > It's actually a good thing that this test case triggers for the kernel > change you're proposing; that change should never be merged. The > user.* namespace is meant for data with the same access permissions as > the file data, and it has been for many years. We may have > applications that assume the existing behavior. In addition, this > change would create backwards compatibility problems for things like > backups. > > I'm not convinced that what you're actually proposing (mapping > security.selinux to a different attribute name) actually makes sense, > but that's a question for the selinux folks to decide. Mapping it to a > user.* attribute is definitely wrong though. The modified behavior > would affect anybody, not only users of selinux and/or virtiofs. If > mapping attribute names is actually the right approach, then you need > to look at trusted.* xattrs, which exist specifically for this kind of > purpose. You've noted that trusted.* xattrs aren't supported over nfs. > That's unfortunate, but not an acceptable excuse for messing up user.* > xattrs. Another possibility would be to make selinux use a different security.* attribute for this nested selinux case. That way, the "host" selinux would retain some control over the labels the "guest" uses. Thanks, Andreas