From: Linus Torvalds <torvalds@linux-foundation.org>
To: Micah Morton <mortonm@chromium.org>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: linux-security-module <linux-security-module@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] SafeSetID MAINTAINERS file update for v5.3
Date: Sun, 4 Aug 2019 10:47:54 -0700 [thread overview]
Message-ID: <CAHk-=wgT7Z3kCbKS9Q1rdA=OVxPL32CdBovX=eHvD2PppWCHpQ@mail.gmail.com> (raw)
In-Reply-To: <CAJ-EccOqmmrf2KPb7Z7NU6bF_4W1XUawLLy=pLekCyFKqusjKQ@mail.gmail.com>
On Thu, Aug 1, 2019 at 11:11 AM Micah Morton <mortonm@chromium.org> wrote:
>
> The following changes since commit 609488bc979f99f805f34e9a32c1e3b71179d10b:
>
> Linux 5.3-rc2 (2019-07-28 12:47:02 -0700)
>
> are available in the Git repository at:
>
> https://github.com/micah-morton/linux.git
> tags/safesetid-maintainers-correction-5.3-rc2
Hmm.
This pull request was apparently not caught by pr-tracker-bot for some
reason, so it didn't get the automated "this has been pulled" message.
I'm not entirely sure why - it was cc'd to lkml, and I see it on lore as
https://lore.kernel.org/lkml/CAJ-EccOqmmrf2KPb7Z7NU6bF_4W1XUawLLy=pLekCyFKqusjKQ@mail.gmail.com/
so the email itself made it through the system. And it has "GIT PULL"
in the subject line, so the pr-tracker-bot should have looked at it.
I see a couple of _potential_ reasons why it might have been overlooked:
- maybe the "--" marker after your explanation made pr-tracker-bot go
"oh, the rest is just a signature"
- the fact that the git link looks more like a regular web thing, and
the branch name is on another line. Does pr-tracker-bot only trigger
on kernel.org things?
- maybe pr-tracker-bot ignores follow-up emails with "Re:" in the subject?
but it could be something else too.
Adding Konstantin to the participants, since he knows the magic.
This is not a big deal, and I have probably missed a lot of other
cases where the pr-tracker-bot doesn't react to pull requests, but I
really like how it gives a heads-up to people about their pulls
without me having to do anything extra, so I generally try to look for
failures when I can.
Konstantin?
Linus
next prev parent reply other threads:[~2019-08-04 17:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 21:30 [GIT PULL] SafeSetID MAINTAINERS file update for v5.3 Micah Morton
2019-08-01 13:25 ` Linus Torvalds
2019-08-01 18:11 ` Micah Morton
2019-08-04 17:07 ` Linus Torvalds
2019-08-04 17:47 ` Linus Torvalds [this message]
2019-08-05 14:27 ` Konstantin Ryabitsev
2019-08-05 18:20 ` Linus Torvalds
2019-08-05 19:11 ` Konstantin Ryabitsev
2019-08-05 19:17 ` Linus Torvalds
2019-08-05 19:27 ` Konstantin Ryabitsev
2019-08-06 16:32 ` Micah Morton
2019-08-07 19:27 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wgT7Z3kCbKS9Q1rdA=OVxPL32CdBovX=eHvD2PppWCHpQ@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=konstantin@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mortonm@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).