From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FC59C0650F for ; Mon, 5 Aug 2019 18:21:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 78D77216B7 for ; Mon, 5 Aug 2019 18:21:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565029281; bh=7ay6wCzrCYZ7STww6F38sr5K1boDOH6OylBRvj6rcbA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=SnL/lf208cGO6IlHNUWeDcJrbBD6j6DWmIotWDjV5lZ2Dg0PYaO+QVbiZfhnTbg2E cwUmcbKh2KqYk4Ap2hG0wCZH9Bk3NBEpKfq42Gm0igbpMHJ2qlNWTAddXC8f3V6rBq pHqCAv85YwRRXPbwlydqqKeXr8H1dbgJjBCrjP2g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728759AbfHESVU (ORCPT ); Mon, 5 Aug 2019 14:21:20 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:36114 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728831AbfHESVT (ORCPT ); Mon, 5 Aug 2019 14:21:19 -0400 Received: by mail-lf1-f68.google.com with SMTP id j17so4745465lfp.3 for ; Mon, 05 Aug 2019 11:21:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WGQ5IB84E7mhKplViJK5IrEC3u7IzYyrnw83fJb3J2I=; b=CLhlvp6oMG8Ynt6VPrXmi8rSjn6ZKK/3dkRZCW83Uk58mLwN52g7vuodlXSP55jKd7 F4LA1YdX8tA54qpVwhkDFvL7lHM6G2zE0lqeWe0lqMijcj8j0HopsDCHXiJ4L55BgPMJ 6kDvCBK2ELmZP/VK4yyFLL/MPNcWLz/M4kXFA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WGQ5IB84E7mhKplViJK5IrEC3u7IzYyrnw83fJb3J2I=; b=ZLSMlyo+69FwQLlJ3pSx2dNCA6rnK5s7hJU261mT8Fb7dsCF8nnQ/bUiDXiWxOI9io ihUUMvpGvdM1UFBOMuxjQNR8R9Zt1NWQ/jXSKKHGddz9R1zkgw65pv68/TPUe/NgV4j/ vLk5Ya0l1E2oR5gdzSCnaiioB0dgUsZ/Uy1zwzkHEjvTQxoA/e/UQGnLIyHbuS1qIK4R fMB7fnwgoQ8UKenKOHksi1JxWpGBdle3PAW7vfi3ni1E8Pgo3XGPlLEpWakTgrgIpztW LXMFi7QS2N9+OTKFVHFTaMMjKRgIIDMrTsvZnUYxfMIZ/GIzemPiXT1oQWRVJHJNB4hR ioIA== X-Gm-Message-State: APjAAAVMtgA0XYKDvKF/ak+e3kWLV1Tk7STizMUOun+6dUSKmaB+mC6j Jw6d1n9k2KTKBmJdfN3yJfkEBKUnrc4= X-Google-Smtp-Source: APXvYqw4V4rC0kcAn2jXqXHnB+zjgUIemTu9+djd+mZD7VhDFss6TnuNKKm244gCcd1FGM02+jgXMA== X-Received: by 2002:a19:cbd3:: with SMTP id b202mr9119518lfg.185.1565029277167; Mon, 05 Aug 2019 11:21:17 -0700 (PDT) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com. [209.85.167.51]) by smtp.gmail.com with ESMTPSA id 189sm16869043lfa.0.2019.08.05.11.21.16 for (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 05 Aug 2019 11:21:16 -0700 (PDT) Received: by mail-lf1-f51.google.com with SMTP id b17so58779848lff.7 for ; Mon, 05 Aug 2019 11:21:16 -0700 (PDT) X-Received: by 2002:ac2:428d:: with SMTP id m13mr7524597lfh.52.1565029275746; Mon, 05 Aug 2019 11:21:15 -0700 (PDT) MIME-Version: 1.0 References: <20190805142756.GA4887@chatter.i7.local> In-Reply-To: <20190805142756.GA4887@chatter.i7.local> From: Linus Torvalds Date: Mon, 5 Aug 2019 11:20:59 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] SafeSetID MAINTAINERS file update for v5.3 To: Konstantin Ryabitsev Cc: Micah Morton , linux-security-module , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Mon, Aug 5, 2019 at 7:28 AM Konstantin Ryabitsev wrote: > > On Sun, Aug 04, 2019 at 10:47:54AM -0700, Linus Torvalds wrote: > > - maybe pr-tracker-bot ignores follow-up emails with "Re:" in the > > subject? > > Yes, this is the culprit. Here are the matching regexes: > > https://git.kernel.org/pub/scm/linux/kernel/git/mricon/korg-helpers.git/tree/pr-tracker-bot.py#n41 > > Normally, pull requests don't come in as replies -- this is the first > one that got missed in months, to my knowledge. Most pull requests certainly are proper starts of threads. And I generally wish they were, because I know I myself tend to skim over emails much more quickly if it's some old discussion that I either consider solved or where somebody else is handling it, so if I see a pull request in the middle of a thread, it's much more likely that I'd miss it. It does happen, though. Not just in situations like this, where I replied to the original pull request with some reason for why I wouldn't pull it, and then the fixed pull came in as part of the thread. Al Viro does that to me occasionally, for example. Some discussion about a vfs problem, and then the pull request is in the middle of that thread. You can see an example of that here: https://lore.kernel.org/lkml/20180125002151.GR13338@ZenIV.linux.org.uk/ although in that case it was Davem who merged it (in merge commit 8ec59b44a006. Of course, pr-tracker-bot wouldn't have noticed that one anyway, because it also doesn't have "GIT PULL" or anything like that in the subject line at all. So maybe it's not a great example. I don't know if it's worth changing the pr-tracker-bot rules. I *do* think that the whole unquoted for you to fetch changes up to [hex string] is by far the strongest single signal for a pull request, but it's not clear that it's worth spending a lot of CPU time looking for that unless you have a strong signal in the subject line. So I consider this "solved", and maybe people should just realize that they won't get the automated responses unless they do everything just right. Linus