From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1717C3A5AA for ; Wed, 4 Sep 2019 22:28:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 708AE21881 for ; Wed, 4 Sep 2019 22:28:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567636106; bh=uDOuymAhR3WDG7e7vxkKlX8QlIfAIuOQLJ96dDSevFI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=ZdLMJ40DMIbN10qyCZqRU/eE/VH+cPext9norpVEPPgmrr0UAoOx3URGahve4RteE 9i4eR0AaiAiyFVFmFfMW1LoBNW2Ud0s636M3M3/gG+/ZZyajhp4dZ2f1V0y3+sI1GU 351loUMGXrFiHjIC2GllLoEGVEA3wAoo+6O+dRQc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730529AbfIDW2Z (ORCPT ); Wed, 4 Sep 2019 18:28:25 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:35211 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730491AbfIDW2Z (ORCPT ); Wed, 4 Sep 2019 18:28:25 -0400 Received: by mail-lf1-f65.google.com with SMTP id w6so309226lfl.2 for ; Wed, 04 Sep 2019 15:28:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=N2MMR8Y9nF2WKJ/GwXu7Orie3221sa5b9mT2pSMScP0=; b=fJ3Uw5l+iJ6RQgyGxaGpdfmIjWnE5F6x31rjDuCqfKxB8VAjbqJtmAWjWR9quPy177 kSc2B1tiYJnm6N1rDryl38O0XT+KrCxDR5lxJB7HlM5pTNWW6oATfW3XbXy7OWukzkZ2 g/kQFWidQUGLu16LN7J3E3MLC7X6Q8WHam9qY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=N2MMR8Y9nF2WKJ/GwXu7Orie3221sa5b9mT2pSMScP0=; b=rfNvkrK/0sNE0SAJKWwgqLkdqg1DfT7mXUGCSisKQtEPaRNvECtI9UtJWZ61lKBZTT 6LeU7EWUA08gdclyEpnJ7eHp7yluVYzzNxqda0Cwz3s5d7OCp9fjQwqmd8PlP4bD+2hH fpmjz39LfaCLA8d7X+PcDBBm+UgOOyLDNCLFzm2CD+sSzCbhhbI2Wt/50Kfa7HnlGWF+ 4GbqSV0t7N+U4n5bBXR0QZt1L4tE4JMY/QSZvMB44W9GaRij+ti6jFroKyaMaVTdMHED 1uy/yYBjINVrS6QLCSKkFahsBasXBwAf7jn+XoZHkUbQLEthqHQ9Llbt47sQEsjssHdj 456w== X-Gm-Message-State: APjAAAV5yOCV5bGSiBcO939dG6wmHNpqlctUOj1IxsOyErIignltVuHh VWgdSuLR+jVpOxEH4mgqOAIQoEadiS8= X-Google-Smtp-Source: APXvYqxxu2fSMsbT3VRzNVygY+C01c/wgyNAmEcNGha5prZTHbTiA/AEiFy/X70QwPdwUGA1ZQpu0Q== X-Received: by 2002:a19:3f47:: with SMTP id m68mr259436lfa.108.1567636103107; Wed, 04 Sep 2019 15:28:23 -0700 (PDT) Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com. [209.85.208.170]) by smtp.gmail.com with ESMTPSA id t11sm18734ljd.19.2019.09.04.15.28.22 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Sep 2019 15:28:22 -0700 (PDT) Received: by mail-lj1-f170.google.com with SMTP id 7so310807ljw.7 for ; Wed, 04 Sep 2019 15:28:22 -0700 (PDT) X-Received: by 2002:a05:651c:1104:: with SMTP id d4mr7069ljo.90.1567636101831; Wed, 04 Sep 2019 15:28:21 -0700 (PDT) MIME-Version: 1.0 References: <156763534546.18676.3530557439501101639.stgit@warthog.procyon.org.uk> In-Reply-To: <156763534546.18676.3530557439501101639.stgit@warthog.procyon.org.uk> From: Linus Torvalds Date: Wed, 4 Sep 2019 15:28:06 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 00/11] Keyrings, Block and USB notifications [ver #8] To: David Howells Cc: keyrings@vger.kernel.org, linux-usb@vger.kernel.org, linux-block , Casey Schaufler , Stephen Smalley , Greg Kroah-Hartman , nicolas.dichtel@6wind.com, raven@themaw.net, Christian Brauner , LSM List , linux-fsdevel , Linux API , Linux List Kernel Mailing Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: Archived-At: List-Archive: List-Post: On Wed, Sep 4, 2019 at 3:15 PM David Howells wrote: > > > Here's a set of patches to add a general notification queue concept and to > add event sources such as: Why? I'm just going to be very blunt about this, and say that there is no way I can merge any of this *ever*, unless other people stand up and say that (a) they'll use it and (b) they'll actively develop it and participate in testing and coding Because I'm simply not willing to have the same situation that happened with the keyring ACL stuff this merge window happen with some other random feature some day in the future. That change never had anybody else that showed any interest in it, it was never really clear why it was made, and it broke booting for me. That had better never happen again, and I'm tired of seeing unexplained random changes to key handling that have one single author and nobody else involved. And there is this whole long cover letter to explain what the code does, what you can do with it, and what the changes have been in revisions, but AT NO POINT does it explain what the point of the feature is at all. Why would we want this, and what is the advantage over udev etc that already has event handling for things like block events and USB events? What's the advantage of another random character device, and what's the use? Who is asking for this, and who would use it? Why are keys special, and why should you be able to track events on keys in the first place? Who is co-developing and testing this, and what's the point? Fundamentally, I'm not even interested in seeing "Reviewed-by". New features need actual users and explanations for what they are, over and beyond the developer itself. IOW, you need to have an outside person step in and say "yes, I need this". No more of these "David makes random changes without any external input" series. Linus