Re: [PATCH] security: declare member holding string literal const

From: "Christian Göttsche" <cgzones@googlemail.com>
To: Paul Moore <paul@paul-moore.com>
Cc: "Casey Schaufler" <casey@schaufler-ca.com>,
	"SElinux list" <selinux@vger.kernel.org>,
	"James Morris" <jmorris@namei.org>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Nick Desaulniers" <ndesaulniers@google.com>,
	"Xin Long" <lucien.xin@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Ondrej Mosnacek" <omosnace@redhat.com>,
	"Mickaël Salaün" <mic@linux.microsoft.com>,
	"Todd Kjos" <tkjos@google.com>,
	"Olga Kornievskaia" <kolga@netapp.com>,
	"Linux kernel mailing list" <linux-kernel@vger.kernel.org>,
	linux-security-module@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] security: declare member holding string literal const
Date: Fri, 13 May 2022 19:16:36 +0200	[thread overview]
Message-ID: <CAJ2a_Ddy8Kkp6SHxktguSQ4WqHwpA=zrQUz8UYkajF5-YtPerw@mail.gmail.com> (raw)
In-Reply-To: <CAHC9VhR-Xk65iSfZxVvaK+mJoFszxT2E8vF=cus1aAKcB0EgYg@mail.gmail.com>

On Tue, 3 May 2022 at 22:02, Paul Moore <paul@paul-moore.com> wrote:
>
> On Mon, May 2, 2022 at 9:38 AM Christian Göttsche
> <cgzones@googlemail.com> wrote:
> > On Thu, 17 Feb 2022 at 23:50, Casey Schaufler <casey@schaufler-ca.com> wrote:
> > > On 2/17/2022 6:18 AM, Christian Göttsche wrote:
> > > > The struct security_hook_list member lsm is assigned in
> > > > security_add_hooks() with string literals passed from the individual
> > > > security modules.  Declare the function parameter and the struct member
> > > > const to signal their immutability.
> > > >
> > > > Reported by Clang [-Wwrite-strings]:
> > > >
> > > >      security/selinux/hooks.c:7388:63: error: passing 'const char [8]' to parameter of type 'char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
> > > >              security_add_hooks(selinux_hooks, ARRAY_SIZE(selinux_hooks), selinux);
> > > >                                                                           ^~~~~~~~~
> > > >      ./include/linux/lsm_hooks.h:1629:11: note: passing argument to parameter 'lsm' here
> > > >                                      char *lsm);
> > > >                                            ^
> > > >
> > > > Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
> > >
> > > Reviewed-by: Casey Schaufler <casey@schaufler-ca.com>
> > >
> >
> > Kindly ping;
> > any progress on this one?
>
> I've already added my Reviewed-by tag, as has Casey, so I think it's
> pretty "safe" at this point.  The next step is for James to pull this
> into the LSM tree.  If it is still collecting dust at the end of this
> week, ping us again and I can just go ahead and pull it into the
> SELinux tree, it's small enough that it shouldn't cause any problems.

end-of-the-week-ping

>
> --
> paul-moore.com