linux-security-module.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nick Desaulniers <ndesaulniers@google.com>
To: Tom Rix <trix@redhat.com>
Cc: mic@digikod.net, Nathan Chancellor <nathan@kernel.org>,
	linux-security-module@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	clang-built-linux <clang-built-linux@googlegroups.com>
Subject: Re: [PATCH] samples/landlock: fix path_list memory leak
Date: Tue, 27 Apr 2021 12:13:50 -0700	[thread overview]
Message-ID: <CAKwvOdmj5YvWZZWwcq1G7JgRALwPbqwiROiedMeEbBst2sGeiQ@mail.gmail.com> (raw)
In-Reply-To: <20210427183755.2790654-1-trix@redhat.com>

On Tue, Apr 27, 2021 at 11:38 AM <trix@redhat.com> wrote:
>
> From: Tom Rix <trix@redhat.com>
>
> Clang static analysis reports this error
>
> sandboxer.c:134:8: warning: Potential leak of memory
>   pointed to by 'path_list'
>         ret = 0;
>               ^
> path_list is allocated in parse_path() but never freed.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  samples/landlock/sandboxer.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/samples/landlock/sandboxer.c b/samples/landlock/sandboxer.c
> index 7a15910d2171..4629d011ed61 100644
> --- a/samples/landlock/sandboxer.c
> +++ b/samples/landlock/sandboxer.c
> @@ -134,6 +134,8 @@ static int populate_ruleset(
>         ret = 0;
>
>  out_free_name:
> +       if (path_list)
> +               free(path_list);

I don't think the conditional is even necessary? By our first `goto
out_free_name;`, `parse_path` has already been called/memory for
`path_list` has already been allocated. `parse_path` doesn't check
whether `malloc` has failed.

>         free(env_path_name);
>         return ret;
>  }
> --
> 2.26.3
>


-- 
Thanks,
~Nick Desaulniers

  reply	other threads:[~2021-04-27 19:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-27 18:37 [PATCH] samples/landlock: fix path_list memory leak trix
2021-04-27 19:13 ` Nick Desaulniers [this message]
2021-04-28  9:58   ` Mickaël Salaün
2021-04-28 15:36     ` Tom Rix
2021-04-28 18:04       ` Mickaël Salaün

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKwvOdmj5YvWZZWwcq1G7JgRALwPbqwiROiedMeEbBst2sGeiQ@mail.gmail.com \
    --to=ndesaulniers@google.com \
    --cc=clang-built-linux@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=mic@digikod.net \
    --cc=nathan@kernel.org \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).