From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C13ABC35254 for ; Mon, 10 Feb 2020 18:23:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 93FF920838 for ; Mon, 10 Feb 2020 18:23:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581359018; bh=t3Wks9ek7HdZAz6PJfkKNyateIsqhC1vSgHRd0AbOp8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=p8o1ypXCKC2YwIVmJ1BKaPIUlNTBrXtmN8HAQgEHzHjXuU79KksCONVJXKVQMgNJ9 P/cwlr29VNovdu3mru5CZCWqI5kC+4UY9mgNCTJL6HHvXH9Uuezq6YSsttC8mWS5go 5/90H/+SXQHkV94zJkqN0/AUvfyKl/sqCBvGHsJg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726831AbgBJSXh (ORCPT ); Mon, 10 Feb 2020 13:23:37 -0500 Received: from mail.kernel.org ([198.145.29.99]:46772 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726816AbgBJSXh (ORCPT ); Mon, 10 Feb 2020 13:23:37 -0500 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0E61D20863 for ; Mon, 10 Feb 2020 18:23:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581359017; bh=t3Wks9ek7HdZAz6PJfkKNyateIsqhC1vSgHRd0AbOp8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=iiK85FFk1llSss7Y+WKoCQhsXOljBpzzUvKnMT33O/2Qb4MLgmoMZsRb/ugOpUOYA maNfzqkY1lGCPD+4umyoaW2df4LcCztXq2pR9ffElISHzDdNZQQxIkNB+SStreUyHy kWIfoQZJbKDHzCBnaTfwpRYalPutSU3oG+LzdppA= Received: by mail-wm1-f47.google.com with SMTP id q9so280235wmj.5 for ; Mon, 10 Feb 2020 10:23:36 -0800 (PST) X-Gm-Message-State: APjAAAU5eOIMv5dktU6J9apnp+/iQkwiiKp/s9FDPR3Urb8VJG+lHrIY T2lO1M+MHmjFXEFxb/2nMvowjvfiJ7BhLFteMSQ73Q== X-Google-Smtp-Source: APXvYqyvQmNAMgah8c6tQsJZ+XZQiG6GIX/jTddr8+dPCUtkW0/ytdNqMktRK7dZRNI8z6/OdYPguTtbJfJo4KyutMo= X-Received: by 2002:a7b:cbcf:: with SMTP id n15mr262021wmi.21.1581359015424; Mon, 10 Feb 2020 10:23:35 -0800 (PST) MIME-Version: 1.0 References: <20200210150519.538333-1-gladkov.alexey@gmail.com> <20200210150519.538333-4-gladkov.alexey@gmail.com> In-Reply-To: <20200210150519.538333-4-gladkov.alexey@gmail.com> From: Andy Lutomirski Date: Mon, 10 Feb 2020 10:23:23 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v8 03/11] proc: move /proc/{self|thread-self} dentries to proc_fs_info To: Alexey Gladkov Cc: LKML , Kernel Hardening , Linux API , Linux FS Devel , Linux Security Module , Akinobu Mita , Alexander Viro , Alexey Dobriyan , Andrew Morton , Andy Lutomirski , Daniel Micay , Djalal Harouni , "Dmitry V . Levin" , "Eric W . Biederman" , Greg Kroah-Hartman , Ingo Molnar , "J . Bruce Fields" , Jeff Layton , Jonathan Corbet , Kees Cook , Linus Torvalds , Oleg Nesterov , Solar Designer Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Mon, Feb 10, 2020 at 7:06 AM Alexey Gladkov wrote: > > This is a preparation patch that moves /proc/{self|thread-self} dentries > to be stored inside procfs fs_info struct instead of making them per pid > namespace. Since we want to support multiple procfs instances we need to > make sure that these dentries are also per-superblock instead of > per-pidns, The changelog makes perfect sense so far... > unmounting a private procfs won't clash with other procfs > mounts. This doesn't parse as part of the previous sentence. I'm also not convinced that this really involves unmounting per se. Maybe just delete these words.