From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0188C4CEC9 for ; Wed, 18 Sep 2019 14:27:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CCBE6218AE for ; Wed, 18 Sep 2019 14:27:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729584AbfIRO1O (ORCPT ); Wed, 18 Sep 2019 10:27:14 -0400 Received: from mail-oi1-f194.google.com ([209.85.167.194]:45107 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727273AbfIRO1O (ORCPT ); Wed, 18 Sep 2019 10:27:14 -0400 Received: by mail-oi1-f194.google.com with SMTP id o205so6088924oib.12; Wed, 18 Sep 2019 07:27:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BHV/5Y+4+cCMm6daXLOGdlbWIRWLheVwhv0/ivXbcAE=; b=nq4h3v3EIBQhp3sB2ecGD04KWW1+dbvayQTY5UyWMQ+3juIbkpnBrygYDCalljWovR BvjDKzzATCSkJxy2GEqac0D8zGjlWecYPftUoq1WULP6PW4GhnQ5sE5etzsbI9IPKvR4 o3BYxgC+y4qec1jlnFJOB3lpVv8ugn28PWdU3dBVkKk4aXbdAZm5E+/VkGENzNFiz3d6 tavhTNupDYcH1G1Cf5bOWge+usJFTC9JuWx6znSigkrXTyr5pN0aNJ5Z1dtpiHiuzL4b M7qBNYwv+nOXFUyFNQ3Vy5dY2lgCIov5rsm4SMrINGfamBstelOuQ1bDmFFouNvKI7v7 Ckcg== X-Gm-Message-State: APjAAAVCNIARJtLNjEMbxFT9W2r/SwIpro32+yuvyek2ftlB8BEfRzdD ndhFsWCuQ9yzp7BY9RIdkHmLxj4ikmeAYV89r/M= X-Google-Smtp-Source: APXvYqzTTZhnmal8UUl1l4fGKNj0vwH/8ztgh2Jwww8ltwigjgo6QuJG49rHLYVXKdkoJ0D+Bgnwc/c/39GCFzhd/4s= X-Received: by 2002:aca:f305:: with SMTP id r5mr2285556oih.131.1568816833580; Wed, 18 Sep 2019 07:27:13 -0700 (PDT) MIME-Version: 1.0 References: <278d9706-162d-28a4-4640-31b697924473@physik.fu-berlin.de> <6304acd1-7b71-b1fb-f8d8-298cb3025e69@physik.fu-berlin.de> <6725b972-05d4-fed4-7094-16401e86b452@gmail.com> <578d8a91-aaee-087f-1742-65e64001b8fa@physik.fu-berlin.de> In-Reply-To: From: Geert Uytterhoeven Date: Wed, 18 Sep 2019 16:27:02 +0200 Message-ID: Subject: Can KEY_DH_OPERATIONS become tristate? (was: Re: Kernel 5.3.0 stuck during boot on Amiga) To: John Paul Adrian Glaubitz Cc: Michael Schmitz , linux-m68k , Mat Martineau , David Howells , James Morris , "Serge E. Hallyn" , keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: CC crypto keys people TL;DR: CONFIG_CRYPTO_DH=y is reported to cause boot delays of several minutes on old and slow machines. Can KEY_DH_OPERATIONS be made tristate? On Wed, Sep 18, 2019 at 4:08 PM Geert Uytterhoeven wrote: > On Wed, Sep 18, 2019 at 3:57 PM John Paul Adrian Glaubitz > wrote: > > On 9/18/19 3:48 PM, Geert Uytterhoeven wrote: > > >> Diffie-Hellman doing some heavy crypto lifting on a poor m68k CPU? > > >> > > >> Disable CONFIG_CRYPTO_DH? > > > > > > See also https://lists.debian.org/debian-68k/2019/04/msg00033.html > > > > > > CRYPTO_DH is selected by CRYPTO_DEV_QAT and KEY_DH_OPERATIONS. > > > The latter is bool, forcing CRYPTO_DH builtin. > > > > > > If KEY_DH_OPERATIONS needs to be enabled in a Debian kernel, perhaps > > > it can be made tristate? > > It was enabled in [1] as it's required for certain WiFi drivers [2]. > > > > So, should it be fixed as you suggest or should we selectively disable it on m68k? > > Disabling it on m68k could be a first step (any WiFi drivers supported > on m68k yet?). > > Making it tristate is non-trivial, as there are some interdependencies: > > security/keys/Makefile:compat-obj-$(CONFIG_KEY_DH_OPERATIONS) += compat_dh.o > security/keys/Makefile:obj-$(CONFIG_KEY_DH_OPERATIONS) += dh.o > security/keys/internal.h:#ifdef CONFIG_KEY_DH_OPERATIONS > security/keys/keyctl.c: > (IS_ENABLED(CONFIG_KEY_DH_OPERATIONS) ? KEYCTL_CAPS0_DIFFIE_HELLMAN > : 0) | > > > > [1] https://salsa.debian.org/kernel-team/linux/commit/88f44cb9eb34098138c79bdab5fae434492866d1 > > > [2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911998 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds