From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92636C433EF for ; Fri, 3 Sep 2021 14:42:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 66633610E9 for ; Fri, 3 Sep 2021 14:42:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349488AbhICOns (ORCPT ); Fri, 3 Sep 2021 10:43:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:47972 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235443AbhICOnr (ORCPT ); Fri, 3 Sep 2021 10:43:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630680167; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EEFnIURrP2vwLaJ5HTfs71djy1e9bipR/GQhDMVx0Ic=; b=bAVFNyI0pzLKjOzg9YZn5dAcZquxCmuGpAOOvvU82xAWDbIEc/XloCD6txfplO6ZlzHk1A mf3MUDHV6FRvXTAOKDpL1RhjPKGHdWyLRWBSrVeV3aFfj267uiGySegfYJyfXqzo1Do/K0 7P8m424H/HTLE2Y9UdVKRcQAIB2Z7Tk= Received: from mail-il1-f199.google.com (mail-il1-f199.google.com [209.85.166.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-176-j_EYMf9LPCCvnKhr6UM_ag-1; Fri, 03 Sep 2021 10:42:46 -0400 X-MC-Unique: j_EYMf9LPCCvnKhr6UM_ag-1 Received: by mail-il1-f199.google.com with SMTP id z14-20020a92d18e0000b029022418b34bc9so3646860ilz.9 for ; Fri, 03 Sep 2021 07:42:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EEFnIURrP2vwLaJ5HTfs71djy1e9bipR/GQhDMVx0Ic=; b=E/9mfXrVWL/M42uEAJVYmeykm7GUuw2JY+ed6KGL/AjcFEzsiifLV5S65WYLq2f6Cg lIkGTs0m0tI+0hGCheOz4gP8zYXbwl7C0zSwHIAYFVzMKFQ28dfz7wMOlk0qQUuc9JKk MW2tQVjvKbUAXKIvT2OyDdKsXKI670hSk8TX5tvtMK+t/fS622zkzU96zX2TyE6Yav4r eBihNSu2aS769VTNMSwbynuWlgIh++Hzgc9aG5tBTM97cA4+jNbQhk4rboSctREmt4mw PjZ9BTvgo2AnhkUrSLayL2M67SdF0WHPLtmGNoZ4J/nJnHOpWjekb7zq2hDphOySeOLv w37Q== X-Gm-Message-State: AOAM531b6LPX4ulr8xHO7ksvVTjoyaE88kAm6qZ0U65FSy5urls5Z2Iv ed1k96azRqeFZMKymgQkllAJPx+JiOIswjcgaaNWKIEik2i9OMBfIFznsJ5nF/rDbO1V8nuc7k6 j/MW4hyuNCzR5h27kgNcbdSQLk8XoqJbhGeswDYx1xho3NaKhjXTU X-Received: by 2002:a05:6e02:e53:: with SMTP id l19mr2910874ilk.108.1630680165300; Fri, 03 Sep 2021 07:42:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw9AT6fUQTezOFBvhyEPkIypPYE9orVd8STwsCxlacI9c6iwGMMi7S2j+q9xU7COfmaPZaiMz+DVo3Ee2EyNoY= X-Received: by 2002:a05:6e02:e53:: with SMTP id l19mr2910849ilk.108.1630680165078; Fri, 03 Sep 2021 07:42:45 -0700 (PDT) MIME-Version: 1.0 References: <20210902152228.665959-1-vgoyal@redhat.com> In-Reply-To: From: Bruce Fields Date: Fri, 3 Sep 2021 10:42:34 -0400 Message-ID: Subject: Re: [PATCH 3/1] xfstests: generic/062: Do not run on newer kernels To: Andreas Gruenbacher Cc: Vivek Goyal , fstests , linux-fsdevel , LKML , virtio-fs@redhat.com, Daniel Walsh , David Gilbert , Christian Brauner , Casey Schaufler , LSM , selinux@vger.kernel.org, "Theodore Ts'o" , Miklos Szeredi , Giuseppe Scrivano , stephen.smalley.work@gmail.com, Dave Chinner , Alexander Viro Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=bfields@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: Well, we could also look at supporting trusted.* xattrs over NFS. I don't know much about them, but it looks like it wouldn't be a lot of work to specify, especially now that we've already got user xattrs? We'd just write a new internet draft that refers to the existing user.* xattr draft for most of the details. --b. On Fri, Sep 3, 2021 at 2:56 AM Andreas Gruenbacher wrote: > > On Fri, Sep 3, 2021 at 8:31 AM Andreas Gruenbacher wrote: > > On Thu, Sep 2, 2021 at 5:47 PM Vivek Goyal wrote: > > > xfstests: generic/062: Do not run on newer kernels > > > > > > This test has been written with assumption that setting user.* xattrs will > > > fail on symlink and special files. When newer kernels support setting > > > user.* xattrs on symlink and special files, this test starts failing. > > > > It's actually a good thing that this test case triggers for the kernel > > change you're proposing; that change should never be merged. The > > user.* namespace is meant for data with the same access permissions as > > the file data, and it has been for many years. We may have > > applications that assume the existing behavior. In addition, this > > change would create backwards compatibility problems for things like > > backups. > > > > I'm not convinced that what you're actually proposing (mapping > > security.selinux to a different attribute name) actually makes sense, > > but that's a question for the selinux folks to decide. Mapping it to a > > user.* attribute is definitely wrong though. The modified behavior > > would affect anybody, not only users of selinux and/or virtiofs. If > > mapping attribute names is actually the right approach, then you need > > to look at trusted.* xattrs, which exist specifically for this kind of > > purpose. You've noted that trusted.* xattrs aren't supported over nfs. > > That's unfortunate, but not an acceptable excuse for messing up user.* > > xattrs. > > Another possibility would be to make selinux use a different > security.* attribute for this nested selinux case. That way, the > "host" selinux would retain some control over the labels the "guest" > uses. > > Thanks, > Andreas >