linux-security-module.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko@kernel.org>
To: Stefan Berger <stefanb@linux.ibm.com>
Cc: peterhuewe@gmx.de, jgg@ziepe.ca, linux-integrity@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] Fix bugs related to TPM2 event log
Date: Thu, 11 Mar 2021 01:04:13 +0200	[thread overview]
Message-ID: <YElQbZy5Z3qn7SVq@kernel.org> (raw)
In-Reply-To: <20210310221916.356716-1-stefanb@linux.ibm.com>

On Wed, Mar 10, 2021 at 05:19:13PM -0500, Stefan Berger wrote:
> This series of patches fixes a couple of issues related to TPM2
> event logs, such as the disappearance of the TPM2 log on QEMU machines
> running with UEFI (my fault) and a kernel fault due to an integer under-
> flow when reading the TPM 2 log multiple times.
> 
> Regards,
>    Stefan
> 
> v1->v2:
>  - Revised patches 1 & 2
> 
> Stefan Berger (3):
>   tpm: efi: Use local variable for calculating final log size
>   tpm: acpi: Check eventlog signature before using it
>   tpm: vtpm_proxy: Avoid reading host log when using a virtual device
> 
>  drivers/char/tpm/eventlog/acpi.c   | 33 +++++++++++++++++++++++++++++-
>  drivers/char/tpm/eventlog/common.c |  3 +++
>  drivers/char/tpm/eventlog/efi.c    | 29 ++++++++++++++++++--------
>  3 files changed, 56 insertions(+), 9 deletions(-)
> 
> -- 
> 2.29.2
> 
> 

b4 seems like remarkably useful tool:

$ b4 am 20210310221916.356716-1-stefanb@linux.ibm.com
Looking up https://lore.kernel.org/r/20210310221916.356716-1-stefanb%40linux.ibm.com
Grabbing thread from lore.kernel.org/linux-integrity
Analyzing 4 messages in the thread
---
Writing ./v2_20210310_stefanb_fix_bugs_related_to_tpm2_event_log.mbx
  ✓ [PATCH v2 1/3] tpm: efi: Use local variable for calculating final log size
  ✓ [PATCH v2 2/3] tpm: acpi: Check eventlog signature before using it
  ✓ [PATCH v2 3/3] tpm: vtpm_proxy: Avoid reading host log when using a virtual device
  ---
  ✓ Attestation-by: DKIM/ibm.com (From: stefanb@linux.ibm.com)
---
Total patches: 3
---
Cover: ./v2_20210310_stefanb_fix_bugs_related_to_tpm2_event_log.cover
 Link: https://lore.kernel.org/r/20210310221916.356716-1-stefanb@linux.ibm.com
 Base: not found (applies clean to current tree)
       git am ./v2_20210310_stefanb_fix_bugs_related_to_tpm2_event_log.mbx

$ git am -3 v2_20210310_stefanb_fix_bugs_related_to_tpm2_event_log.mbx
Applying: tpm: efi: Use local variable for calculating final log size
Applying: tpm: acpi: Check eventlog signature before using it
Applying: tpm: vtpm_proxy: Avoid reading host log when using a virtual device

I also did run checkpatch.pl, no errors.

/Jarkko

      parent reply	other threads:[~2021-03-10 23:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10 22:19 [PATCH v2 0/3] Fix bugs related to TPM2 event log Stefan Berger
2021-03-10 22:19 ` [PATCH v2 1/3] tpm: efi: Use local variable for calculating final log size Stefan Berger
2021-03-10 23:14   ` Jarkko Sakkinen
2021-03-10 23:21   ` Jarkko Sakkinen
2021-03-10 23:24     ` Jarkko Sakkinen
2021-03-11 14:02       ` Stefan Berger
2021-03-12 16:54         ` Jarkko Sakkinen
2021-03-10 22:19 ` [PATCH v2 2/3] tpm: acpi: Check eventlog signature before using it Stefan Berger
2021-03-10 23:13   ` Jarkko Sakkinen
2021-03-10 22:19 ` [PATCH v2 3/3] tpm: vtpm_proxy: Avoid reading host log when using a virtual device Stefan Berger
2021-03-10 23:04   ` Jarkko Sakkinen
2021-03-10 23:04 ` Jarkko Sakkinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YElQbZy5Z3qn7SVq@kernel.org \
    --to=jarkko@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    --cc=stefanb@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).