From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80EE9C4332F for ; Mon, 16 May 2022 18:38:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345005AbiEPSi3 (ORCPT ); Mon, 16 May 2022 14:38:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345002AbiEPSi2 (ORCPT ); Mon, 16 May 2022 14:38:28 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 511723E5E9; Mon, 16 May 2022 11:38:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0DF63B815B4; Mon, 16 May 2022 18:38:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14C94C385AA; Mon, 16 May 2022 18:38:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652726303; bh=0QvHgpJb4KFdSPQhvpkbywnyC2wGLiX11TmowfYp2s0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iF8HVDkBiP42BWNMLdac03I5u5aAhpR+vhIMwoa1mpYAaeYITtvbtHdkiVBaFM65S kNFEIyXvMAgnIU/eU4Uq1bQ34AV2coojUp23sJhrEQcmDO7s8O+cDWA9rgtdm+v45d MeQpFXSpV6GLLbFtK4a9TDdVHeJCbXjNz5xEHMv0sj4VuaCGZoapoXf7TFScaVAAcf UBAgyQC1Iga4ix6xqfX1RsHzYCqIN2AXwApLthNoENTq030XBy4B6qmqfhhbz5aCHA AGCf6Z8xnfs0RE3ctYQViFD3MbP2MHvEMCQDZMFjGCipUhJboRCZKJPzRsNBRmDaPO h0Ql4Y/5m2G/g== Date: Mon, 16 May 2022 21:36:48 +0300 From: Jarkko Sakkinen To: Ahmad Fatoum Cc: Horia =?utf-8?Q?Geant=C4=83?= , Mimi Zohar , Pankaj Gupta , Herbert Xu , "David S. Miller" , James Bottomley , kernel@pengutronix.de, David Howells , James Morris , "Serge E. Hallyn" , Steffen Trumtrar , Jan Luebbe , David Gstir , Eric Biggers , Richard Weinberger , Franck LENORMAND , Sumit Garg , Andreas Rammhold , Tim Harvey , Matthias Schiffer , Michael Walle , John Ernberg , linux-integrity@vger.kernel.org, keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH v10 0/7] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys Message-ID: References: <20220513145705.2080323-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220513145705.2080323-1-a.fatoum@pengutronix.de> Precedence: bulk List-ID: On Fri, May 13, 2022 at 04:56:58PM +0200, Ahmad Fatoum wrote: > Series applies on top of v5.18-rc6. Would be great if this could make it > into v5.19. > > v9 was here: > https://lore.kernel.org/linux-integrity/20220506062553.1068296-1-a.fatoum@pengutronix.de > > Changelog is beneath each individual patch. Compared to v9, only code > change is checking whether CAAM can support blobbing at init-time for > CAAM revisions < 10 (such as LS1046A) to avoid a cryptic error message > at first use. > > > The Cryptographic Acceleration and Assurance Module (CAAM) is an IP core > built into many newer i.MX and QorIQ SoCs by NXP. > > Its blob mechanism can AES encrypt/decrypt user data using a unique > never-disclosed device-specific key. > > There has been multiple discussions on how to represent this within the kernel: > > The Cryptographic Acceleration and Assurance Module (CAAM) is an IP core > built into many newer i.MX and QorIQ SoCs by NXP. > > Its blob mechanism can AES encrypt/decrypt user data using a unique > never-disclosed device-specific key. There has been multiple > discussions on how to represent this within the kernel: > > - [RFC] crypto: caam - add red blobifier > Steffen implemented[1] a PoC sysfs driver to start a discussion on how to > best integrate the blob mechanism. > Mimi suggested that it could be used to implement trusted keys. > Trusted keys back then were a TPM-only feature. > > - security/keys/secure_key: Adds the secure key support based on CAAM. > Udit Agarwal added[2] a new "secure" key type with the CAAM as backend. > The key material stays within the kernel only. > Mimi and James agreed that this needs a generic interface, not specific > to CAAM. Mimi suggested trusted keys. Jan noted that this could serve as > basis for TEE-backed keys. > > - [RFC] drivers: crypto: caam: key: Add caam_tk key type > Franck added[3] a new "caam_tk" key type based on Udit's work. This time > it uses CAAM "black blobs" instead of "red blobs", so key material stays > within the CAAM and isn't exposed to kernel in plaintext. > James voiced the opinion that there should be just one user-facing generic > wrap/unwrap key type with multiple possible handlers. > David suggested trusted keys. > > - Introduce TEE based Trusted Keys support > Sumit reworked[4] trusted keys to support multiple possible backends with > one chosen at boot time and added a new TEE backend along with TPM. > This now sits in Jarkko's master branch to be sent out for v5.13 > > This patch series builds on top of Sumit's rework to have the CAAM as yet another > trusted key backend. > > The CAAM bits are based on Steffen's initial patch from 2015. His work had been > used in the field for some years now, so I preferred not to deviate too much from it. > > This series has been tested with dmcrypt[5] on an i.MX6Q/DL, i.MX8M[6] > and LS1028[7]. > > Looking forward to your feedback. > > Cheers, > Ahmad > > [1]: https://lore.kernel.org/linux-crypto/1447082306-19946-2-git-send-email-s.trumtrar@pengutronix.de/ > [2]: https://lore.kernel.org/linux-integrity/20180723111432.26830-1-udit.agarwal@nxp.com/ > [3]: https://lore.kernel.org/lkml/1551456599-10603-2-git-send-email-franck.lenormand@nxp.com/ > [4]: https://lore.kernel.org/lkml/1604419306-26105-1-git-send-email-sumit.garg@linaro.org/ > [5]: https://lore.kernel.org/linux-integrity/20210122084321.24012-2-a.fatoum@pengutronix.de/ > [6]: https://lore.kernel.org/linux-integrity/DU2PR04MB8630D83FE9BBC0D782C4FAF595089@DU2PR04MB8630.eurprd04.prod.outlook.com/ > [7]: https://lore.kernel.org/linux-integrity/49e1738c55c73819ee0e2cac0be74d81@walle.cc/ > > --- > To: Jarkko Sakkinen > To: "Horia Geantă" > To: Mimi Zohar > To: Pankaj Gupta > To: Herbert Xu > To: "David S. Miller" > To: James Bottomley > Cc: David Howells > Cc: James Morris > Cc: "Serge E. Hallyn" > Cc: Steffen Trumtrar > Cc: Jan Luebbe > Cc: David Gstir > Cc: Eric Biggers > Cc: Richard Weinberger > Cc: Franck LENORMAND > Cc: Sumit Garg > Cc: Andreas Rammhold > Cc: Tim Harvey > Cc: Matthias Schiffer > Cc: Michael Walle > Cc: John Ernberg > Cc: linux-integrity@vger.kernel.org > Cc: keyrings@vger.kernel.org > Cc: linux-crypto@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-security-module@vger.kernel.org > > > > Ahmad Fatoum (7): > KEYS: trusted: allow use of TEE as backend without TCG_TPM support > KEYS: trusted: allow use of kernel RNG for key material > crypto: caam - determine whether CAAM supports blob encap/decap > crypto: caam - add in-kernel interface for blob generator > KEYS: trusted: Introduce support for NXP CAAM-based trusted keys > doc: trusted-encrypted: describe new CAAM trust source > MAINTAINERS: add KEYS-TRUSTED-CAAM > > .../admin-guide/kernel-parameters.txt | 11 ++ > .../security/keys/trusted-encrypted.rst | 60 +++++- > MAINTAINERS | 9 + > drivers/crypto/caam/Kconfig | 3 + > drivers/crypto/caam/Makefile | 1 + > drivers/crypto/caam/blob_gen.c | 182 ++++++++++++++++++ > drivers/crypto/caam/ctrl.c | 17 +- > drivers/crypto/caam/intern.h | 1 + > drivers/crypto/caam/regs.h | 4 +- > include/keys/trusted-type.h | 2 +- > include/keys/trusted_caam.h | 11 ++ > include/soc/fsl/caam-blob.h | 103 ++++++++++ > security/keys/Kconfig | 18 +- > security/keys/trusted-keys/Kconfig | 38 ++++ > security/keys/trusted-keys/Makefile | 10 +- > security/keys/trusted-keys/trusted_caam.c | 80 ++++++++ > security/keys/trusted-keys/trusted_core.c | 45 ++++- > 17 files changed, 563 insertions(+), 32 deletions(-) > create mode 100644 drivers/crypto/caam/blob_gen.c > create mode 100644 include/keys/trusted_caam.h > create mode 100644 include/soc/fsl/caam-blob.h > create mode 100644 security/keys/trusted-keys/Kconfig > create mode 100644 security/keys/trusted-keys/trusted_caam.c > > -- > 2.30.2 > I can probably pick these unless objections? BR, Jarkko