From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BF05C00449 for ; Wed, 3 Oct 2018 19:04:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D224213A2 for ; Wed, 3 Oct 2018 19:04:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D224213A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=namei.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-security-module-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726966AbeJDBxk (ORCPT ); Wed, 3 Oct 2018 21:53:40 -0400 Received: from namei.org ([65.99.196.166]:35460 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726964AbeJDBxk (ORCPT ); Wed, 3 Oct 2018 21:53:40 -0400 Received: from localhost (localhost [127.0.0.1]) by namei.org (8.14.4/8.14.4) with ESMTP id w93J3uum016824; Wed, 3 Oct 2018 19:03:56 GMT Date: Thu, 4 Oct 2018 05:03:56 +1000 (AEST) From: James Morris To: David Howells cc: denkenz@gmail.com, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/22] KEYS: Provide missing asymmetric key subops for new key type ops In-Reply-To: <153618447788.7946.12036865757091293640.stgit@warthog.procyon.org.uk> Message-ID: References: <153618445730.7946.10001472635835806478.stgit@warthog.procyon.org.uk> <153618447788.7946.12036865757091293640.stgit@warthog.procyon.org.uk> User-Agent: Alpine 2.21 (LRH 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Wed, 5 Sep 2018, David Howells wrote: > +int asymmetric_key_eds_op(struct kernel_pkey_params *params, > + const void *in, void *out) > +{ > + const struct asymmetric_key_subtype *subtype; > + struct key *key = params->key; > + int ret; > + > + pr_devel("==>%s()\n", __func__); Are you planning on leaving these pr_devel()s in? -- James Morris