From: James Morris <jmorris@namei.org>
To: Micah Morton <mortonm@chromium.org>
Cc: kbuild-all@01.org, linux-security-module@vger.kernel.org,
james.morris@microsoft.com
Subject: Re: [PATCH] LSM: SafeSetID: remove unused include
Date: Thu, 31 Jan 2019 07:30:58 +1100 (AEDT) [thread overview]
Message-ID: <alpine.LRH.2.21.1901310730520.10106@namei.org> (raw)
In-Reply-To: <20190130155643.167055-1-mortonm@chromium.org>
On Wed, 30 Jan 2019, mortonm@chromium.org wrote:
> From: Micah Morton <mortonm@chromium.org>
>
> The include for asm/syscall.h was needed in a prior version of lsm.c
> that checked return values of syscall_get_nr, but since we did away with
> that part of the code this include is no longer necessary. Take out this
> include since it breaks builds for certain architectures. We no longer
> have any arch-specific code in SafeSetID.
>
> Signed-off-by: Micah Morton <mortonm@chromium.org>
Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-general
> ---
> security/safesetid/lsm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/security/safesetid/lsm.c b/security/safesetid/lsm.c
> index 282a242beb86..cecd38e2ac80 100644
> --- a/security/safesetid/lsm.c
> +++ b/security/safesetid/lsm.c
> @@ -14,7 +14,6 @@
>
> #define pr_fmt(fmt) "SafeSetID: " fmt
>
> -#include <asm/syscall.h>
> #include <linux/hashtable.h>
> #include <linux/lsm_hooks.h>
> #include <linux/module.h>
>
--
James Morris
<jmorris@namei.org>
prev parent reply other threads:[~2019-01-30 20:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 0:33 [security:next-general 83/85] security/safesetid/lsm.c:17:10: fatal error: asm/syscall.h: No such file or directory kbuild test robot
2019-01-30 15:56 ` [PATCH] LSM: SafeSetID: remove unused include mortonm
2019-01-30 20:30 ` James Morris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.21.1901310730520.10106@namei.org \
--to=jmorris@namei.org \
--cc=james.morris@microsoft.com \
--cc=kbuild-all@01.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mortonm@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).